Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verifier presentation failure adjustments #830

Merged
merged 2 commits into from
May 5, 2023

Conversation

bobozaur
Copy link
Contributor

@bobozaur bobozaur commented May 5, 2023

This PR fixes an emerging problem regarding the verifier not doing anything in case the presentation verification fails (a problem report might be generated, but not sent, so the prover would be in the dark).

…ion failure

Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
@bobozaur bobozaur marked this pull request as ready for review May 5, 2023 08:39
@codecov-commenter
Copy link

codecov-commenter commented May 5, 2023

Codecov Report

Merging #830 (de7d800) into main (07c35cb) will increase coverage by 0.01%.
The diff coverage is 81.25%.

@@            Coverage Diff             @@
##             main     #830      +/-   ##
==========================================
+ Coverage   49.00%   49.01%   +0.01%     
==========================================
  Files         410      410              
  Lines       33495    33500       +5     
  Branches     7436     7451      +15     
==========================================
+ Hits        16413    16421       +8     
+ Misses      11968    11965       -3     
  Partials     5114     5114              
Flag Coverage Δ
unittests-aries-vcx 48.98% <81.25%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ocols/proof_presentation/verifier/state_machine.rs 49.05% <81.25%> (+1.78%) ⬆️

... and 2 files with indirect coverage changes

Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
@Patrik-Stas Patrik-Stas merged commit 616968e into main May 5, 2023
41 checks passed
@Patrik-Stas Patrik-Stas deleted the hotfix/presentation_fails branch May 5, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants