Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/notification problem report #833

Merged
merged 7 commits into from
May 12, 2023
Merged

Conversation

bobozaur
Copy link
Contributor

@bobozaur bobozaur commented May 9, 2023

As per the RFC the ProblemReport message can be a part of the notification message family (which only contains the ack message that's borrowed to other protocols).

This PR adds a ProblemReport message to the protocol to match the AFJ implementation (which is, technically, correct).

@codecov-commenter
Copy link

codecov-commenter commented May 9, 2023

Codecov Report

Merging #833 (e9b5339) into main (a7cc540) will increase coverage by 0.34%.
The diff coverage is 33.33%.

❗ Current head e9b5339 differs from pull request most recent head 3de6bc3. Consider uploading reports for the commit 3de6bc3 to get more accurate results

@@            Coverage Diff             @@
##             main     #833      +/-   ##
==========================================
+ Coverage   48.73%   49.07%   +0.34%     
==========================================
  Files         404      412       +8     
  Lines       32680    33575     +895     
  Branches     7192     7449     +257     
==========================================
+ Hits        15925    16477     +552     
- Misses      11910    11985      +75     
- Partials     4845     5113     +268     
Flag Coverage Δ
unittests-aries-vcx 49.04% <33.33%> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ies_vcx/src/common/primitives/credential_schema.rs 46.45% <ø> (ø)
aries_vcx/src/handlers/util.rs 16.25% <0.00%> (-0.21%) ⬇️
aries_vcx/src/protocols/connection/generic/mod.rs 35.58% <ø> (ø)
aries_vcx/src/protocols/connection/invitee/mod.rs 69.44% <ø> (ø)
aries_vcx/src/protocols/issuance/actions.rs 35.29% <0.00%> (-5.62%) ⬇️
...vcx/src/protocols/issuance/holder/state_machine.rs 42.41% <0.00%> (-0.31%) ⬇️
...vcx/src/protocols/issuance/issuer/state_machine.rs 48.65% <0.00%> (ø)
...ocols/mediated_connection/invitee/state_machine.rs 51.98% <ø> (ø)
...rc/protocols/proof_presentation/prover/messages.rs 23.07% <0.00%> (-5.05%) ⬇️
...otocols/proof_presentation/prover/state_machine.rs 31.42% <0.00%> (-0.74%) ⬇️
... and 16 more

... and 28 files with indirect coverage changes

@bobozaur bobozaur force-pushed the fix/notification_problem_report branch from 7c55f33 to e9b5339 Compare May 9, 2023 19:48
@bobozaur bobozaur marked this pull request as ready for review May 9, 2023 19:48
Patrik-Stas
Patrik-Stas previously approved these changes May 10, 2023
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
…ate new possible ProblemReport type

Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
@bobozaur bobozaur force-pushed the fix/notification_problem_report branch from 3de6bc3 to b1b8e32 Compare May 10, 2023 22:18
@Patrik-Stas Patrik-Stas merged commit 6c09d75 into main May 12, 2023
42 checks passed
@Patrik-Stas Patrik-Stas deleted the fix/notification_problem_report branch May 12, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants