-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/notification problem report #833
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #833 +/- ##
==========================================
+ Coverage 48.73% 49.07% +0.34%
==========================================
Files 404 412 +8
Lines 32680 33575 +895
Branches 7192 7449 +257
==========================================
+ Hits 15925 16477 +552
- Misses 11910 11985 +75
- Partials 4845 5113 +268
Flags with carried forward coverage won't be shown. Click here to find out more.
|
bobozaur
force-pushed
the
fix/notification_problem_report
branch
from
May 9, 2023 19:48
7c55f33
to
e9b5339
Compare
Patrik-Stas
reviewed
May 10, 2023
Patrik-Stas
reviewed
May 10, 2023
aries_vcx/src/protocols/proof_presentation/verifier/state_machine.rs
Outdated
Show resolved
Hide resolved
Patrik-Stas
previously approved these changes
May 10, 2023
bobozaur
force-pushed
the
fix/notification_problem_report
branch
from
May 10, 2023 22:18
e37adb1
to
3de6bc3
Compare
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
…ate new possible ProblemReport type Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
bobozaur
force-pushed
the
fix/notification_problem_report
branch
from
May 10, 2023 22:18
3de6bc3
to
b1b8e32
Compare
Patrik-Stas
reviewed
May 11, 2023
Patrik-Stas
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the RFC the
ProblemReport
message can be a part of thenotification
message family (which only contains theack
message that's borrowed to other protocols).This PR adds a
ProblemReport
message to the protocol to match the AFJ implementation (which is, technically, correct).