Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split publish_local_revocations in BaseAnoncreds #838

Merged
merged 3 commits into from
May 12, 2023

Conversation

mirgee
Copy link
Contributor

@mirgee mirgee commented May 12, 2023

Splits publish_local_revocations method associated with BaseAnoncreds trait into get_rev_reg_delta and clear_rev_reg_delta in order for IndySdkAnonCreds to not depend on a PoolHandle. Local revocations' publishing is now implemented in an already existing method associated with RevocationRegistry which exposes this functionality to the client code.

Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
@mirgee mirgee added the skip-ci label May 12, 2023
@mirgee mirgee marked this pull request as ready for review May 12, 2023 08:34
@mirgee mirgee removed the skip-ci label May 12, 2023
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
@codecov-commenter
Copy link

codecov-commenter commented May 12, 2023

Codecov Report

Merging #838 (8d858c6) into main (244b8b3) will increase coverage by 0.09%.
The diff coverage is 59.67%.

@@            Coverage Diff             @@
##             main     #838      +/-   ##
==========================================
+ Coverage   48.99%   49.09%   +0.09%     
==========================================
  Files         410      412       +2     
  Lines       33585    33646      +61     
  Branches     7449     7456       +7     
==========================================
+ Hits        16455    16517      +62     
+ Misses      12018    12014       -4     
- Partials     5112     5115       +3     
Flag Coverage Δ
unittests-aries-vcx 49.06% <59.67%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s_vcx/src/utils/mockdata/profile/mock_anoncreds.rs 42.37% <0.00%> (-1.11%) ⬇️
aries_vcx_core/src/anoncreds/credx_anoncreds.rs 52.60% <0.00%> (-0.37%) ⬇️
...cx_core/src/indy/primitives/revocation_registry.rs 67.74% <0.00%> (+6.67%) ⬆️
...s_vcx/src/common/primitives/revocation_registry.rs 45.45% <31.25%> (-1.02%) ⬇️
aries_vcx_core/src/anoncreds/indy_anoncreds.rs 76.92% <62.50%> (-2.10%) ⬇️
aries_vcx/tests/utils/scenarios.rs 80.99% <85.71%> (-0.05%) ⬇️
aries_vcx/src/common/anoncreds.rs 79.68% <100.00%> (ø)
aries_vcx/src/common/credentials/mod.rs 73.33% <100.00%> (+0.29%) ⬆️
aries_vcx/src/common/test_utils.rs 92.94% <100.00%> (+0.02%) ⬆️
aries_vcx/src/core/profile/vdrtools_profile.rs 83.33% <100.00%> (ø)
... and 1 more

... and 29 files with indirect coverage changes

Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
@Patrik-Stas Patrik-Stas merged commit e7a62de into main May 12, 2023
42 checks passed
@Patrik-Stas Patrik-Stas deleted the refactor/split-publish-local-revocations branch May 12, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants