Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/protocols problem report #840

Merged
merged 4 commits into from
May 12, 2023
Merged

Conversation

bobozaur
Copy link
Contributor

This PR addresses #835 and #836, essentially adding a ProblemReport message to both the IssueCredential and PresentProof protocols.

@codecov-commenter
Copy link

codecov-commenter commented May 12, 2023

Codecov Report

Merging #840 (794b6d3) into main (a7cc540) will decrease coverage by 40.40%.
The diff coverage is 3.38%.

@@            Coverage Diff             @@
##             main    #840       +/-   ##
==========================================
- Coverage   49.09%   8.69%   -40.40%     
==========================================
  Files         410     408        -2     
  Lines       33517   32854      -663     
  Branches     7443    7211      -232     
==========================================
- Hits        16456    2858    -13598     
- Misses      11948   29189    +17241     
+ Partials     5113     807     -4306     
Flag Coverage Δ
unittests-aries-vcx 8.69% <3.38%> (-40.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ies_vcx/src/common/primitives/credential_schema.rs 27.55% <ø> (-18.90%) ⬇️
aries_vcx/src/handlers/util.rs 7.22% <0.00%> (-9.23%) ⬇️
aries_vcx/src/protocols/connection/generic/mod.rs 35.58% <ø> (ø)
aries_vcx/src/protocols/connection/invitee/mod.rs 69.44% <ø> (ø)
aries_vcx/src/protocols/issuance/actions.rs 0.00% <0.00%> (-40.91%) ⬇️
...vcx/src/protocols/issuance/holder/state_machine.rs 0.00% <0.00%> (-42.73%) ⬇️
...vcx/src/protocols/issuance/issuer/state_machine.rs 0.00% <0.00%> (-48.66%) ⬇️
...ocols/mediated_connection/invitee/state_machine.rs 0.00% <ø> (-51.99%) ⬇️
...rc/protocols/proof_presentation/prover/messages.rs 0.00% <0.00%> (-28.13%) ⬇️
...otocols/proof_presentation/prover/state_machine.rs 0.00% <0.00%> (-32.16%) ⬇️
... and 20 more

... and 282 files with indirect coverage changes

Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
@bobozaur bobozaur force-pushed the fix/protocols_problem_report branch from b1ea2f2 to 794b6d3 Compare May 12, 2023 13:49
@Patrik-Stas Patrik-Stas merged commit 52e9c71 into main May 12, 2023
42 checks passed
@Patrik-Stas Patrik-Stas deleted the fix/protocols_problem_report branch May 12, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ProblemReport to the IssueCredential message family Add ProblemReport to the PresentProof message family
4 participants