refactor maybe_known.rs: MaybeKnown enum

[nachiketkanore]

• fixes Move MaybeKnown enum to shared_vcx #839

[codecov-commenter]

Codecov Report

Merging #842 (7dade1e) into main (5ecad0a) will increase coverage by 0.00%.
The diff coverage is 25.00%.

@@           Coverage Diff           @@
##             main     #842   +/-   ##
=======================================
  Coverage   49.01%   49.01%           
=======================================
  Files         414      414           
  Lines       33694    33694           
  Branches     7445     7446    +1     
=======================================
+ Hits        16515    16516    +1     
  Misses      12062    12062           
+ Partials     5117     5116    -1     

Flag	Coverage Δ
unittests-aries-vcx	48.98% <25.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
aries_vcx/src/handlers/out_of_band/sender.rs	56.33% <ø> (ø)
...s_vcx/src/protocols/revocation_notification/mod.rs	0.00% <ø> (ø)
.../revocation_notification/receiver/state_machine.rs	0.00% <ø> (ø)
...ls/revocation_notification/sender/state_machine.rs	32.05% <ø> (ø)
messages/src/decorators/thread.rs	50.00% <ø> (ø)
messages/src/lib.rs	75.00% <ø> (ø)
...msg_fields/protocols/discover_features/disclose.rs	75.00% <ø> (ø)
.../src/msg_fields/protocols/discover_features/mod.rs	77.27% <ø> (ø)
...rc/msg_fields/protocols/discover_features/query.rs	71.42% <ø> (ø)
...src/msg_fields/protocols/out_of_band/invitation.rs	52.17% <ø> (ø)
... and 3 more

... and 1 file with indirect coverage changes

[bobozaur]

Great job! There are just some small nitpicks that I commented on, but overall looks good. Thank you for picking this up!

[bobozaur]

@nachiketkanore Did you merge main by any chance? If that's the case, we'd prefer if you rebased instead.

[nachiketkanore]

Yes, I merged

[bobozaur]

Yes, I merged

Would you be so kind to rebase instead?

[nachiketkanore]

Yes, I merged

Would you be so kind to rebase instead?

Sorry for not following the guidelines. I am new to this, will check and update accordingly!

UPD: I have rebased the main branch, let me know if there are any more issues. Thanks!

[bobozaur]

LGTM overall, though I'd find it awesome if you also used some custom type for the Unknown variant in the tests as well. But that can also be done sometime later and it's not really a dealbreaker.

Provided that the CI runs successfully, I'm okay with merging this.

[bobozaur]

Yes, I merged

Would you be so kind to rebase instead?

Sorry for not following the guidelines. I am new to this, will check and update accordingly!

UPD: I have rebased the main branch, let me know if there are any more issues. Thanks!

It's all good, we all gotta start somewhere :).