-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support referrent-explicit format creating presentation request #844
Conversation
Codecov Report
@@ Coverage Diff @@
## main #844 +/- ##
==========================================
- Coverage 49.00% 8.70% -40.30%
==========================================
Files 414 408 -6
Lines 33694 32864 -830
Branches 7446 7200 -246
==========================================
- Hits 16512 2862 -13650
- Misses 12066 29191 +17125
+ Partials 5116 811 -4305
Flags with carried forward coverage won't be shown. Click here to find out more.
|
64922e1
to
3b0ef07
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments about readability mainly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a short discussion with @Patrik-Stas who pointed out this is kind of legacy code and will most likely get refactored soon.
Since previous comments were mainly about readability, I have no problem with merging this as-is now.
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
3b0ef07
to
58d01a8
Compare
<predicate_info>
objects (as they are defined in https://hyperledger.github.io/anoncreds-spec/#create-presentation-request). Aries-vcx implementation then auto-generated referent names, eg given:we transformed the input internally to anoncreds format
requested_predicates
object (as per anoncreds link above) and therefore letting the caller specify referents names eg.This is useful capability when inspecting presentations.
Note
aries-vcx