Implement txn endorsing for IndyVdrLedger #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Codecov Report
@@ Coverage Diff @@
## main #852 +/- ##
========================================
- Coverage 8.70% 8.69% -0.02%
========================================
Files 408 408
Lines 32868 32911 +43
Branches 7207 7215 +8
========================================
Hits 2861 2861
- Misses 29196 29239 +43
Partials 811 811
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mirgee
force-pushed
the
feature/endorse-txn
branch
from
da84ec4
to
94b8c9b
Compare
mirgee
force-pushed
the
feature/endorse-txn
branch
2 times, most recently
from
e15f5a4
to
56640e6
Compare
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
mirgee
force-pushed
the
feature/endorse-txn
branch
from
56640e6
to
43a5b89
Compare
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
mirgee
force-pushed
the
feature/endorse-txn
branch
from
43a5b89
to
e7e8245
Compare
Patrik-Stas
reviewed
May 19, 2023
| Ok(()) | ||
| let mut request = self._build_schema_request(submitter_did, schema_json)?; | ||
| request = _append_txn_author_agreement_to_request(request).await?; | ||
| if let Some(endorser_did) = endorser_did { |
There was a problem hiding this comment.
this endorsing sequence is missing for other publish_* methods, but I see that we don't even pass endorses_did Option in those. Okay, I guess that could be another github issue (perhaps even good-first-issue, should be fairly simple)
There was a problem hiding this comment.
This is just replicating the current vdrtools implementation. They should behave identically and fixes like this should be done on both until we remove the vdrtools one.
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa> # Conflicts: # aries_vcx_core/src/ledger/indy_vdr_ledger.rs
Patrik-Stas
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
endorse_transaction,set_endorserandget_txn_author_agreementforIndyVdrLedgerand enablestest_endorse_transactiontest.