Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on BaseWallet from IndyVdrLedger #853

Merged
merged 8 commits into from
May 19, 2023

Conversation

mirgee
Copy link
Contributor

@mirgee mirgee commented May 18, 2023

Remove dependency on BaseWallet from IndyVdrLedger in favor of injecting a singing-specific trait implementation.

Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
@mirgee mirgee force-pushed the refactor/indy-vdr-ledger-remove-base-wallet branch from 880e2d0 to f930306 Compare May 18, 2023 09:12
@codecov-commenter
Copy link

codecov-commenter commented May 18, 2023

Codecov Report

Merging #853 (1adbd52) into main (77310eb) will increase coverage by 0.01%.
The diff coverage is 64.28%.

@@            Coverage Diff             @@
##             main     #853      +/-   ##
==========================================
+ Coverage   49.05%   49.06%   +0.01%     
==========================================
  Files         423      424       +1     
  Lines       34077    34084       +7     
  Branches     7528     7529       +1     
==========================================
+ Hits        16717    16724       +7     
- Misses      12166    12167       +1     
+ Partials     5194     5193       -1     
Flag Coverage Δ
unittests-aries-vcx 49.03% <64.28%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
..._vcx_core/src/ledger/request_signer/base_wallet.rs 50.00% <50.00%> (ø)
aries_vcx/src/core/profile/modular_libs_profile.rs 83.33% <100.00%> (ø)
aries_vcx_core/src/ledger/indy_vdr_ledger.rs 30.65% <100.00%> (+0.33%) ⬆️

... and 2 files with indirect coverage changes

@mirgee mirgee marked this pull request as ready for review May 18, 2023 10:58
{
pub wallet: Arc<dyn BaseWallet>,
pub request_signer: Arc<U>,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Patrik-Stas
Patrik-Stas previously approved these changes May 18, 2023
@Patrik-Stas
Copy link
Contributor

Patrik-Stas commented May 18, 2023

@mirgee perhaps this can be cherry picked out out of from top of feature/endorse-txn directly on main? Then we wouldn't have to wait for other stuff to merge, seem like these are pretty self-contained and independent changes

@mirgee
Copy link
Contributor Author

mirgee commented May 18, 2023

@mirgee That would not be as simple and straightforward as it might perhaps seem. Of course the conflicts can be fixed, but I don't see a reason to rush this in.

Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
@mirgee mirgee force-pushed the refactor/indy-vdr-ledger-remove-base-wallet branch from f930306 to 923cfa4 Compare May 19, 2023 06:53
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
@mirgee mirgee force-pushed the refactor/indy-vdr-ledger-remove-base-wallet branch from 923cfa4 to a63c376 Compare May 19, 2023 10:59
Base automatically changed from feature/endorse-txn to main May 19, 2023 14:37
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>

# Conflicts:
#	aries_vcx/src/core/profile/modular_libs_profile.rs
#	aries_vcx/src/core/profile/vdr_proxy_profile.rs
#	aries_vcx_core/src/ledger/indy_vdr_ledger.rs
#	did_resolver_sov/src/reader/vdr_reader.rs
@Patrik-Stas Patrik-Stas merged commit dc69b63 into main May 19, 2023
29 of 33 checks passed
@Patrik-Stas Patrik-Stas deleted the refactor/indy-vdr-ledger-remove-base-wallet branch May 19, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants