Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In memory response cacher #855

Merged
merged 10 commits into from
May 22, 2023
Merged

In memory response cacher #855

merged 10 commits into from
May 22, 2023

Conversation

mirgee
Copy link
Contributor

@mirgee mirgee commented May 18, 2023

Implements a simple naive in-memory ledger response cacher and uses it in IndyVdrLedger.

Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
@codecov-commenter
Copy link

codecov-commenter commented May 18, 2023

Codecov Report

Merging #855 (b8dd068) into main (dc69b63) will decrease coverage by 40.37%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #855       +/-   ##
==========================================
- Coverage   49.06%   8.69%   -40.37%     
==========================================
  Files         424     408       -16     
  Lines       34084   32911     -1173     
  Branches     7529    7215      -314     
==========================================
- Hits        16722    2861    -13861     
- Misses      12167   29239    +17072     
+ Partials     5195     811     -4384     
Flag Coverage Δ
unittests-aries-vcx 8.69% <ø> (-40.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aries_vcx/src/utils/devsetup.rs 30.93% <ø> (-36.79%) ⬇️

... and 314 files with indirect coverage changes

Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
@mirgee mirgee force-pushed the refactor/indy-vdr-ledger-remove-base-wallet branch from f930306 to 923cfa4 Compare May 19, 2023 06:53
@mirgee mirgee force-pushed the feature/response-cacher branch 3 times, most recently from 681f198 to 2371cfe Compare May 19, 2023 08:49
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
@mirgee mirgee force-pushed the refactor/indy-vdr-ledger-remove-base-wallet branch from 923cfa4 to a63c376 Compare May 19, 2023 10:59
@mirgee mirgee force-pushed the feature/response-cacher branch 5 times, most recently from 02b4dd1 to 671eb84 Compare May 19, 2023 11:51
@mirgee mirgee marked this pull request as ready for review May 19, 2023 12:21
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Copy link
Contributor

@Patrik-Stas Patrik-Stas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments

Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Base automatically changed from refactor/indy-vdr-ledger-remove-base-wallet to main May 19, 2023 15:25
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>

# Conflicts:
#	aries_vcx/src/core/profile/modular_libs_profile.rs
#	aries_vcx/src/core/profile/vdr_proxy_profile.rs
#	aries_vcx_core/Cargo.toml
#	aries_vcx_core/src/ledger/indy_vdr_ledger.rs
#	did_resolver_sov/src/reader/vdr_reader.rs
Copy link
Contributor

@bobozaur bobozaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a quick look.

@Patrik-Stas Patrik-Stas merged commit 516cd3a into main May 22, 2023
41 checks passed
@Patrik-Stas Patrik-Stas deleted the feature/response-cacher branch May 22, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants