Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade messages_macros deps to latest #857

Merged
merged 1 commit into from
May 20, 2023

Conversation

swaptr
Copy link
Contributor

@swaptr swaptr commented May 19, 2023

Updated message macros dependencies to latest. Fixes #846

@codecov-commenter
Copy link

codecov-commenter commented May 19, 2023

Codecov Report

Merging #857 (638859d) into main (dc69b63) will decrease coverage by 0.27%.
The diff coverage is n/a.

❗ Current head 638859d differs from pull request most recent head 4bf3754. Consider uploading reports for the commit 4bf3754 to get more accurate results

@@            Coverage Diff             @@
##             main     #857      +/-   ##
==========================================
- Coverage   49.06%   48.79%   -0.27%     
==========================================
  Files         424      423       -1     
  Lines       34084    34027      -57     
  Branches     7529     7516      -13     
==========================================
- Hits        16722    16605     -117     
- Misses      12167    12283     +116     
+ Partials     5195     5139      -56     
Flag Coverage Δ
unittests-aries-vcx 48.77% <ø> (-0.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 14 files with indirect coverage changes

@Patrik-Stas Patrik-Stas requested a review from bobozaur May 19, 2023 15:26
Signed-off-by: Swapnil Tripathi <swapnil06.st@gmail.com>
@bobozaur bobozaur force-pushed the messages_macros-deps-upgrade branch from 638859d to 4bf3754 Compare May 19, 2023 16:10
Copy link
Contributor

@bobozaur bobozaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If the CI runs then I'm okay with merging this.

@Patrik-Stas Patrik-Stas merged commit 1711b3d into hyperledger:main May 20, 2023
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update dependencies of messages_macros crate
4 participants