Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify BFT validator requirements #1081

Merged
merged 2 commits into from
Jul 6, 2022

Conversation

rolandtyler
Copy link
Contributor

@rolandtyler rolandtyler commented Jul 5, 2022

Signed-off-by: Roland Tyler roland.tyler@consensys.net

Pull request checklist

Use the following list to make sure your PR fits the Besu documentation quality standard.

Before creating the pull request

Make sure that:

Describe the change

Clarify BFT validator requirements

Issue fixed

Fixes #1066

Impacted parts

For content changes:

  • Documentation content
  • Documentation page organization

For tool changes:

  • CircleCI workflow
  • Build and QA tools (for example, lint or vale)
  • MkDocs templates
  • MkDocs configuration
  • Python dependencies
  • Node dependencies and JavaScript
  • Read the Docs configuration
  • GitHub integration

After creating your PR and tests have finished

Make sure that:

Preview

https://hyperledger-besu--1081.org.readthedocs.build/en/1081/HowTo/Configure/Consensus-Protocols/QBFT/
https://hyperledger-besu--1081.org.readthedocs.build/en/1081/HowTo/Configure/Consensus-Protocols/IBFT/

Signed-off-by: Roland Tyler <roland.tyler@consensys.net>
@rolandtyler rolandtyler requested a review from a team as a code owner July 5, 2022 16:07
Copy link
Contributor

@alexandratran alexandratran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link to kiln to fix to pass tests

@rolandtyler rolandtyler merged commit 9018c03 into hyperledger:main Jul 6, 2022
@rolandtyler rolandtyler deleted the Update-BFT-requirements branch July 6, 2022 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix BFT validator requirements
3 participants