Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jemalloc as linux prereq #1319

Merged
merged 5 commits into from May 9, 2023

Conversation

alexandratran
Copy link
Contributor

Pull request checklist

Use the following list to make sure your PR fits the Besu documentation quality standard.

Before creating the pull request

Make sure that:

Describe the change

Document jemalloc as prerequisite for installing Besu on Linux.

Issue fixed

fixes #1289

Impacted parts

For content changes:

  • Documentation content
  • Documentation page organization

For tool changes:

  • Github Actions workflow
  • Build and QA tools configuration (for example, lint rules or Vale style)
  • MkDocs templates
  • MkDocs configuration
  • Python dependencies
  • Node dependencies and JavaScript
  • Read the Docs configuration
  • GitHub integration

After creating your PR and tests have finished

Make sure that:

Preview

Signed-off-by: Alexandra Tran <alexandra.tran@consensys.net>
@alexandratran alexandratran requested a review from a team as a code owner May 4, 2023 21:03
@alexandratran alexandratran requested a review from siladu May 4, 2023 21:03
Signed-off-by: Alexandra Tran <alexandra.tran@consensys.net>
Copy link
Contributor

@siladu siladu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but it's not a pre-requisite, it's an optional, recommended performance improvement

Signed-off-by: Alexandra Tran <alexandra.tran@consensys.net>
@alexandratran alexandratran requested a review from siladu May 8, 2023 20:28
Signed-off-by: Alexandra Tran <alexandra.tran@consensys.net>
Copy link
Contributor

@siladu siladu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@bgravenorst bgravenorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexandratran alexandratran merged commit e024a39 into hyperledger:main May 9, 2023
9 checks passed
@alexandratran alexandratran deleted the 1289-jemalloc branch May 9, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to install jemalloc
3 participants