Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the ethical ads div #576

Merged

Conversation

NicolasMassart
Copy link
Contributor

@NicolasMassart NicolasMassart commented Dec 16, 2020

Pull request checklist

Use the following list to make sure your PR fits the Besu doc quality standard.

Before creating the pull request

Make sure that:

After creating your pull request and tests finished

Make sure that:

  • you fixed all the issues raised by the tests, if any.
  • you verified the rendering of your changes on ReadTheDocs.org PR preview
    and updated the testing link (see Testing).

Describe the change

Add the Ethical ads div code

Issue fixed

fixes #575

Impacted parts

For content changes

  • Doc content
  • Doc pages organisation

For tools changes

  • CircleCI workflow
  • Build and QA tools (lint, vale,…)
  • MkDocs templates
  • MkDocs configuration
  • Python dependencies
  • Node dependencies and JavaScript
  • ReadTheDocs configuration
  • GitHub integration

Testing

see https://hyperledger-besu--576.org.readthedocs.build/en/576/

Screenshots / recording

image

Signed-off-by: Nicolas MASSART <nicolas.massart@consensys.net>
@NicolasMassart NicolasMassart requested a review from a team as a code owner December 16, 2020 16:27
@NicolasMassart NicolasMassart self-assigned this Dec 16, 2020
@NicolasMassart NicolasMassart added the DocOps Related to documentation system, tools and CI label Dec 16, 2020
Signed-off-by: Nicolas MASSART <nicolas.massart@consensys.net>
Copy link
Contributor

@bgravenorst bgravenorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@NicolasMassart NicolasMassart merged commit 62449d9 into hyperledger:master Jan 27, 2021
@NicolasMassart NicolasMassart deleted the 575-get-ethical-ads-back branch August 2, 2021 15:27
@alexandratran alexandratran mentioned this pull request Mar 7, 2022
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DocOps Related to documentation system, tools and CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get ReadTheDocs Ethical Ads back to support the service
2 participants