Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added permissions-nodes-contract-version flag #607

Closed
wants to merge 1 commit into from

Conversation

adityajoshi12
Copy link

Added --permissions-nodes-contract-version flag while setting up the Onchain Permissioning/

Pull request checklist

Use the following list to make sure your PR fits the Besu doc quality standard.

Before creating the pull request

Make sure that:

After creating your pull request and tests finished

Make sure that:

  • you fixed all the issues raised by the tests, if any.
  • you verified the rendering of your changes on ReadTheDocs.org PR preview
    and updated the testing link (see Testing).

Describe the change

Issue fixed

Impacted parts

For content changes

  • Doc content
  • Doc pages organisation

For tools changes

  • CircleCI workflow
  • Build and QA tools (lint, vale,…)
  • MkDocs templates
  • MkDocs configuration
  • Python dependencies
  • Node dependencies and JavaScript
  • ReadTheDocs configuration
  • GitHub integration

Testing

Screenshots / recording

Added --permissions-nodes-contract-version flag while setting up the Onchain Permissioning/
@adityajoshi12 adityajoshi12 requested a review from a team as a code owner February 13, 2021 12:51
@bgravenorst
Copy link
Contributor

Hi @adityajoshi12, thanks for your submission!

I've been working on a related documentation fix and incorporated your change into my PR. See #608.

Do you mind if I close this issue, and include your update in my PR?

@adityajoshi12
Copy link
Author

Please go ahead.

@bgravenorst
Copy link
Contributor

Implemented in #608.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants