Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new ipa-multipoint library integration #56

Merged
merged 7 commits into from
Apr 15, 2022

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Mar 20, 2022

No description provided.

@atoulme atoulme force-pushed the ipa-multipoint branch 3 times, most recently from 721eb1d to 85dd3ad Compare March 20, 2022 07:23
@gballet
Copy link

gballet commented Mar 20, 2022

Context for this PR: verkle trees replace hashes with polynomial commitments. These polynomials are computed over an elliptic curve, called bandersnatch. This PR provides the function that takes the coefficients of the polynomial and evaluates it: It's, therefore, the basic building block of verkle trees.

@atoulme atoulme force-pushed the ipa-multipoint branch 4 times, most recently from 14b06a7 to 4095c08 Compare March 20, 2022 22:36
Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com>
Copy link

@gballet gballet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple nitpicks

ipa-multipoint/ipa_multipoint_jni/Cargo.toml Outdated Show resolved Hide resolved
ipa-multipoint/ipa_multipoint_jni/Cargo.toml Outdated Show resolved Hide resolved
Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com>
.gitmodules Outdated Show resolved Hide resolved
Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com>
Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com>
Copy link
Contributor

@garyschulte garyschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't meaningfully comment on the rust impl. Feedback about multi-arch darwin jars should be easy to implement

build.sh Outdated Show resolved Hide resolved
Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com>
Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com>
Copy link
Contributor

@garyschulte garyschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants