Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve DNS use from Ethstats #3792

Closed
jflo opened this issue May 5, 2022 · 7 comments
Closed

Improve DNS use from Ethstats #3792

jflo opened this issue May 5, 2022 · 7 comments
Assignees
Labels
good first issue Good for newcomers TeamGroot GH issues worked on by Groot Team

Comments

@jflo
Copy link
Contributor

jflo commented May 5, 2022

Besu needs DNS/IP:Port whereas others allow for just DNS and let the reverse proxy route them to the correct port. My reverse proxy forwards the traffic to the new ethstats server, but Besu doesn't like that since it tries to send traffic to the port 3000 of the specified DNS server (doesn't touch the reverse proxy then).

So I can switch to IP:Port of the new server, but I'd say this is a QoL thing that should be fixed.

Acceptance Criteria

  • Besu continues reporting to an Ethstats server that has changed it's ip/port under it's DNS entry.

Steps to Reproduce (Bug)

  1. Change the IP of a reverse proxy between Besu and Ethstats

Expected behavior: Reporting continues

Actual behavior: Reporting stops, error message in logs saying:

Failed to reach the ethstats server finishConnect(..) failed: Connection refused: ethstats.mainnetshadowfork3.ethdevops.io/164.92.169.47:3000

@usmansaleem
Copy link
Member

networkaddress.cache.ttl

@usmansaleem
Copy link
Member

usmansaleem commented Apr 5, 2023

@jflo hey Justin, can you ping me either on Discord or slack, I would like to chat about this ticket. One possible solution is to add system property networkaddress.cache.ttl=60 in Besu startup script. The other bit that I want to revalidate from you if the IP address of reverse proxy host is changing more often or the IP address of ethstats is changing more often?

@usmansaleem
Copy link
Member

The other option is to modify the ethstats connecting code and set https://vertx.io/docs/apidocs/io/vertx/core/dns/AddressResolverOptions.html#setCacheMaxTimeToLive-int-.

@usmansaleem
Copy link
Member

@non-fungible-nelson hey Matt, can you ping me regarding above issue, I want to get some further clarification from the user regarding the above issue and whether it is already sorted out or not. Cheers, Uzi.

@non-fungible-nelson
Copy link
Contributor

@jflo might know this - based on the mainnet shadow fork logs, this is likely also with the EF. @usmansaleem did you connect with @parithosh on the improvements?

@parithosh
Copy link
Contributor

@siladu gave me an image to test out and that showed no ethstats issues, I'm honestly not sure which branch or fix he gave me to try, but perhaps he can chime in

@usmansaleem
Copy link
Member

@parithosh That was probably cut againt the main branch that contained the ethstats related enhancements. Next Besu release should also contain these fixes. I am going to close this ticket, in case you face any issues, feel free to re-open this issue or create a new one. Thanks, /uzi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers TeamGroot GH issues worked on by Groot Team
Projects
None yet
Development

No branches or pull requests

5 participants