Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ethstats connection won't be retried properly if the ethstats server runs with TLS/SSL #4696

Closed
skylenet opened this issue Nov 17, 2022 · 1 comment
Assignees
Labels
bug Something isn't working good first issue Good for newcomers TeamGroot GH issues worked on by Groot Team

Comments

@skylenet
Copy link
Contributor

Description

When forwarding metrics via the --ethstats flag to an ethstats server that serves under TLS/SSL, besu falls back to plain HTTP if the TLS connection fails and will never try again. The only way to establish a connection again is by restarting besu and hoping that the first connectivity attempt works.

Acceptance Criteria

Besu should be able to try to reconnect to an ethstats server that has TLS/SSL configured.

Steps to Reproduce (Bug)

1 Have a ethstats server (I'll name it ethstats.local:443 on the following steps) running with TLS/SSL
2. Stop the ethstats server to simulate that it's not available.
3. Run besu with --ethstats=mynode:mysecret@ethstats.local:443
4. See that it will log something like 2022-11-17 12:46:54.910+00:00 | vert.x-eventloop-thread-4 | ERROR | EthStatsService | Failed to reach the ethstats server Failed to create SSL connection (trying without ssl)
5. Start the ethstats server with TLS/SSL
6. Notice that besu won't be able to connect to it because it won't retry with TLS/SSL again. It will stick to plain HTTP.

Versions (Add all that apply)

  • Software version: [besu --version]: hyperledger/besu:22.10.0
@non-fungible-nelson non-fungible-nelson added the bug Something isn't working label Jan 26, 2023
@non-fungible-nelson
Copy link
Contributor

reprioritizing - Pari from EF devops has asked for some of this. alongside #3792

@macfarla macfarla added good first issue Good for newcomers TeamGroot GH issues worked on by Groot Team labels Mar 20, 2023
@usmansaleem usmansaleem self-assigned this Mar 27, 2023
@jframe jframe closed this as completed Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers TeamGroot GH issues worked on by Groot Team
Projects
None yet
Development

No branches or pull requests

5 participants