Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log Bonsai Use Snapshots Config Options at Startup #4683

Open
siladu opened this issue Nov 15, 2022 · 3 comments
Open

Log Bonsai Use Snapshots Config Options at Startup #4683

siladu opened this issue Nov 15, 2022 · 3 comments
Labels

Comments

@siladu
Copy link
Contributor

siladu commented Nov 15, 2022

Following #4451, we should log whether bonsai-use-snapshots is enabled

If you use a toml file to configure besu, it can be hard to tell what options are actually live on a deployment.

Logging at startup would be a simple solution to this, though we need to consider if this could leak any sensitive information.

@gfukushima
Copy link
Contributor

Think #4451 fixes this.

@siladu
Copy link
Contributor Author

siladu commented Nov 25, 2022

Thanks @gfukushima I missed this PR.

It does cover my description of the issue, however presence of --Xbonsai-use-snapshots was the reason I created it and unfortunately @daniellehrner's PR doesn't print that - was there a reason for that? EDIT: thinking about it, maybe it's because that option is going to be defaulted to true and then removed?

For now, I will edit this issue to include this flag

Alternatively, I think it would better if we didn't have to remember to add new options into this config print code...but I wonder if the reason is to avoid accidentally printing sensitive information - what do you think @daniellehrner?

@siladu siladu changed the title Log Config Options at Startup Log Bonsai Use Snapshots Config Options at Startup Nov 25, 2022
@daniellehrner
Copy link
Contributor

I think when I created the config overview bonsai snapshots was not yet implemented. There is no other reason for it not being there.

I think as long as the flag exists it makes sense to print it in the overview as well. Should it be removed in the future we simply can remove it from the overview as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants