You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It does cover my description of the issue, however presence of --Xbonsai-use-snapshots was the reason I created it and unfortunately @daniellehrner's PR doesn't print that - was there a reason for that? EDIT: thinking about it, maybe it's because that option is going to be defaulted to true and then removed?
For now, I will edit this issue to include this flag
Alternatively, I think it would better if we didn't have to remember to add new options into this config print code...but I wonder if the reason is to avoid accidentally printing sensitive information - what do you think @daniellehrner?
siladu
changed the title
Log Config Options at Startup
Log Bonsai Use Snapshots Config Options at Startup
Nov 25, 2022
I think when I created the config overview bonsai snapshots was not yet implemented. There is no other reason for it not being there.
I think as long as the flag exists it makes sense to print it in the overview as well. Should it be removed in the future we simply can remove it from the overview as well.
Following #4451, we should log whether bonsai-use-snapshots is enabled
If you use a toml file to configure besu, it can be hard to tell what options are actually live on a deployment.Logging at startup would be a simple solution to this, though we need to consider if this could leak any sensitive information.The text was updated successfully, but these errors were encountered: