Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prints configuration overview #4451

Merged
merged 6 commits into from
Nov 22, 2022

Conversation

daniellehrner
Copy link
Contributor

@daniellehrner daniellehrner commented Sep 27, 2022

Signed-off-by: Daniel Lehrner daniel.lehrner@consensys.net

PR description

Prints an overview of configuration and system information at startup. This is considered a first version and mainly intended to help debug issues that users on Ethereum Mainnet experience.

Screenshot from 2022-09-28 09-12-20

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if
    updates are required.

Changelog

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
@daniellehrner daniellehrner changed the title generate NetworkDeprecationMessage with FramedLogMessage Prints configuration overview Sep 27, 2022
@daniellehrner daniellehrner marked this pull request as ready for review September 27, 2022 19:58
Copy link
Member

@lucassaldanha lucassaldanha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@fab-10 fab-10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be possible to add the details of jemalloc if on Linux here?
Now it is done here , also to double check it is actually used by Besu a command like this could be executed lsof -p<BESUPID> -n | grep -F jemalloc

@antonydenyer
Copy link
Member

I suspect this is only really useful when reporting bugs, would it make more sense to stick it in its own subcommand?

Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. couple of comments

CHANGELOG.md Outdated
### Additions and Improvements
- Print an overview of configuration and system information at startup [#4451](https://github.com/hyperledger/besu/pull/4451)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will need moving

}

if (isHighSpec) {
lines.add("High spec configuration enabled");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RocksDB high spec configuration enabled ?

@macfarla
Copy link
Contributor

I like this idea

@daniellehrner daniellehrner enabled auto-merge (squash) November 22, 2022 13:19
@daniellehrner daniellehrner merged commit 49f32ca into hyperledger:main Nov 22, 2022
garyschulte pushed a commit to garyschulte/besu that referenced this pull request Nov 22, 2022
* print configuration overview at startup

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
@daniellehrner daniellehrner deleted the config_overview_log branch November 23, 2022 14:02
macfarla pushed a commit to jflo/besu that referenced this pull request Jan 10, 2023
* print configuration overview at startup

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
* print configuration overview at startup

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants