-
Notifications
You must be signed in to change notification settings - Fork 838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prints configuration overview #4451
Prints configuration overview #4451
Conversation
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be possible to add the details of jemalloc
if on Linux here?
Now it is done here , also to double check it is actually used by Besu a command like this could be executed lsof -p<BESUPID> -n | grep -F jemalloc
I suspect this is only really useful when reporting bugs, would it make more sense to stick it in its own subcommand? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. couple of comments
CHANGELOG.md
Outdated
### Additions and Improvements | ||
- Print an overview of configuration and system information at startup [#4451](https://github.com/hyperledger/besu/pull/4451) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will need moving
} | ||
|
||
if (isHighSpec) { | ||
lines.add("High spec configuration enabled"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RocksDB high spec configuration enabled ?
I like this idea |
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* print configuration overview at startup Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
* print configuration overview at startup Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
* print configuration overview at startup Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
Signed-off-by: Daniel Lehrner daniel.lehrner@consensys.net
PR description
Prints an overview of configuration and system information at startup. This is considered a first version and mainly intended to help debug issues that users on Ethereum Mainnet experience.
Documentation
doc-change-required
label to this PR ifupdates are required.
Changelog