Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cli option to specify the name of the loadbalancer used by the Kubernetes nat manager #1078

Merged

Conversation

matkt
Copy link
Contributor

@matkt matkt commented Jun 15, 2020

PR description

Add cli option to specify the name of the loadbalancer used by the Kubernetes nat manager
--Xnat-kube-pod-name

We can specify the name of the load balancer

---
apiVersion: v1
kind: Service
metadata:
  labels:
    app.kubernetes.io/name: besu
    app.kubernetes.io/release: "1.0.0"
  name: besu-custom-name
spec:
  ports:
  - name: "json-rpc"
    port: 8545
    targetPort: 8545
  - name: "rlpx"
    port: 30303
    targetPort: 30303
  selector:
    app.kubernetes.io/name: besu
    app.kubernetes.io/release: "1.0.0"
  type: LoadBalancer

And add the BESU_XNAT_KUBE_POD_NAMEon the deployment script of Besu to specify the name.

---
apiVersion: v1
kind: ConfigMap
metadata:
  name: besu-config
  labels:
    app.kubernetes.io/name: besu
    app.kubernetes.io/release: 1.0.0
data:
  BESU_LOGGING: "DEBUG"
  ....
  BESU_XNAT_KUBE_POD_NAME: "besu-custom-name"
  KUBE_CONFIG_PATH: "/opt/besu/shared/kube-config"
---

Tested

  • With Kubernetes (valid and invalid parameters)
  • Without Kubernetes (valid and invalid parameters)

Fixed Issue(s)

Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
@matkt matkt self-assigned this Jun 15, 2020
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
@matkt matkt marked this pull request as ready for review June 15, 2020 16:59
Copy link
Contributor

@AbdelStark AbdelStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main concern is about testing. Feel free to ignore comments not related to testing.

Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Copy link
Contributor

@AbdelStark AbdelStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

…onfigurable

Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
@matkt matkt merged commit 2ef6fe4 into hyperledger:master Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants