Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Astor testnet #2017

Merged
merged 2 commits into from Mar 14, 2021
Merged

Add Astor testnet #2017

merged 2 commits into from Mar 14, 2021

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Mar 14, 2021

Signed-off-by: Antoine Toulme antoine@lunar-ocean.com

PR description

Adds a tesnet configuration for the Astor testnet

Changelog

@atoulme atoulme force-pushed the astor branch 2 times, most recently from e8b34a6 to 9bfdc60 Compare March 14, 2021 08:57
shemnon
shemnon approved these changes Mar 14, 2021
View reviewed changes
Copy link
Contributor

@shemnon shemnon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a website for Astor like Goerli and Kotti has? If so can you drop it in the commit message?

Also, what happens if Magneto forks before ecip1049 and ecip1049 forks?

@atoulme
Copy link
Contributor Author

atoulme commented Mar 14, 2021

No idea about the latter.

@atoulme
Add Astor testnet, see https://astor.host
c6845fe 
Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com>
@atoulme atoulme enabled auto-merge (squash) March 14, 2021 18:41
@atoulme atoulme merged commit ec5e121 into hyperledger:master Mar 14, 2021
@MadelineMurray MadelineMurray mentioned this pull request Mar 15, 2021
Closed
@atoulme atoulme deleted the astor branch March 15, 2021 06:32
RichardH92 pushed a commit to RichardH92/besu that referenced this pull request Mar 29, 2021
@atoulme @RichardH92
Add Astor testnet, see https://astor.host (hyperledger#2017)
08639b6 
Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com>
Signed-off-by: Richard Hart <richardhart92@gmail.com>
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
@atoulme @eum602
Add Astor testnet, see https://astor.host (hyperledger#2017)
1ab6bed 
Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shemnon shemnon shemnon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@atoulme @shemnon