Fix bonsai storage inconsistency issue #2492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
garyschulte
approved these changes
Jul 2, 2021
| if (persistedHeader.isEmpty()) { | ||
| getTrieLogLayer(persistedState.blockHash()).ifPresent(rollBacks::add); | ||
| } else { | ||
| BlockHeader targetHeader = blockchain.getBlockHeader(blockHash).get(); |
There was a problem hiding this comment.
non-blocking: it would help with readability to resolve the Optional persistedHeader once here and use it in the rest of the block. all of the naked Optional.get() make me nervous (despite being safe here). If we had a small refactor of the flow, those get's could be landmines
Comment on lines
+156
to
+158
| assertThat(bonsaiWorldStateArchive.getMutable(null, blockHeader.getHash())) | ||
| .containsInstanceOf(BonsaiPersistedWorldState.class); | ||
|
|
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Jul 6, 2021
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
RatanRSur
pushed a commit
to RatanRSur/besu
that referenced
this pull request
Jul 8, 2021
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
RatanRSur
pushed a commit
to RatanRSur/besu
that referenced
this pull request
Jul 8, 2021
Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>
RatanRSur
pushed a commit
to RatanRSur/besu
that referenced
this pull request
Jul 8, 2021
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
RatanRSur
pushed a commit
to RatanRSur/besu
that referenced
this pull request
Jul 8, 2021
Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
This ticket fixes a consistency issue between the blockchain storage part and the worldstate storage .
Fixed Issue(s)
Changelog