EIP-3074 #2636
EIP-3074 #2636
Conversation
Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com>
Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com>
Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com>
Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com>
Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com>
…yet, since authcall allows to send from completely new accounts Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com>
| } | ||
|
|
||
| @Override | ||
| protected Wei apparentValue(final MessageFrame frame) { |
There was a problem hiding this comment.
What does "apparent" refer to here?
|
|
||
| @Override | ||
| protected UInt256 inputDataOffset(final MessageFrame frame) { | ||
| return frame.getStackItem(3); |
There was a problem hiding this comment.
Looks like valueExt is missing here, it should be the top - 3 stack element.
| Optional.of(cost(frame)), Optional.of(ExceptionalHaltReason.INSUFFICIENT_GAS)); | ||
| } | ||
| } | ||
| return super.execute(frame, evm); |
There was a problem hiding this comment.
Can't seem to find the logic to ensure that if the gas operand is 0, all but one 64th of the remaining gas is passed to the subcall.
| } | ||
|
|
||
| @Override | ||
| protected OperationResult executeFixedCostOperation(final MessageFrame frame, final EVM evm) { |
There was a problem hiding this comment.
Not sure if someone up the call tree authorized is cleared, but in the case of a ecrecover failure it should clear the current authorized address and push 0 on the stack.
|
FYI, we made a small update to EIP-3074 to include I think that change should pretty much resolve all outstanding issues we have with 3074, so I think it is the now the most stable we can expect it to be. |
|
Going to close as this PR is now old, and didn't follow the latest changes of the EIP. |
Signed-off-by: Antoine Toulme antoine@lunar-ocean.com
PR description
This adds the auth and authcall opcodes of EIP-3074 to Besu, as well as the Puxi testnet definition.
The PR is not ready for merge. It needs thorough review.
See #2637
Changelog