Privacy multitenancy cli option #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
usmansaleem
reviewed
Dec 18, 2019
|
|
||
| @Test | ||
| public void privacyMultiTenancyWithoutAuthenticationFails() { | ||
| final URL configFile = this.getClass().getResource("/orion_publickey.pub"); |
There was a problem hiding this comment.
you may avoid it by declaring static final constant variable, but its not a show-stopper.
usmansaleem
reviewed
Dec 18, 2019
| public boolean isMultiTenancyEnabled() { | ||
| return multiTenancyEnabled; | ||
| } | ||
|
|
||
| @Override | ||
| public String toString() { | ||
| return "PrivacyParameters{" + "enabled=" + enabled + ", enclaveUri='" + enclaveUri + '\'' + '}'; |
There was a problem hiding this comment.
may be add multi-tenancy in toString method as well?
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
usmansaleem
approved these changes
Dec 18, 2019
edwardmack
pushed a commit
to ChainSafe/besu
that referenced
this pull request
Feb 4, 2020
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
edwardmack
pushed a commit
to ChainSafe/besu
that referenced
this pull request
Feb 4, 2020
Signed-off-by: Jason Frame <jasonwframe@gmail.com> Signed-off-by: edwardmack <ed@edwardmack.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Add a privacy multi-tenancy CLI option which is hidden for now. This flag will be used to enable the multi-tenancy privacy mode.
Fixed Issue(s)