Use token enclave public key when in privacy multi-tenancy mode #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
…oller Signed-off-by: Jason Frame <jasonwframe@gmail.com>
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
usmansaleem
reviewed
Dec 20, 2019
|
|
||
| public class PrivFindPrivacyGroupTest { | ||
| private static final String ENCLAVE_PUBLIC_KEY = "A1aVtMxLCUHmBVHXoZzzBgPbW/wj5axDpW9X8l91SGo="; | ||
| private static final List<String> ADDRESSES = |
There was a problem hiding this comment.
we have List.of available as well in core Java.
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
…he enclave public key resolution out of the privacy controller Signed-off-by: Jason Frame <jasonwframe@gmail.com>
rain-on
approved these changes
Dec 22, 2019
jframe
changed the title
edwardmack
pushed a commit
to ChainSafe/besu
that referenced
this pull request
Feb 4, 2020
…rledger#272) Signed-off-by: Jason Frame <jasonwframe@gmail.com>
edwardmack
pushed a commit
to ChainSafe/besu
that referenced
this pull request
Feb 4, 2020
…rledger#272) Signed-off-by: Jason Frame <jasonwframe@gmail.com> Signed-off-by: edwardmack <ed@edwardmack.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
This provides the multi-tenancy enclave public key from the request when the user is using privacy multi-tenancy. Also changes the API of the PrivacyController to now have an optional enclave public key. This will allow the privacy controller in the future to be able to verify enclave operation is allowed for the supplied enclave public key.
Fixed Issue(s)