Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#538] Add a bash/zsh autocomplete script to distributions #2854

Merged
merged 1 commit into from Oct 7, 2021
Merged

[#538] Add a bash/zsh autocomplete script to distributions #2854

merged 1 commit into from Oct 7, 2021

Conversation

diega
Copy link
Contributor

@diega diega commented Oct 5, 2021

PR description

This PR adds bash/zsh autocomplete support using PicoCLI Command Line Completion.

Fixed Issue(s)

Fixes #538

Running

The simpler way to see how it works is within a Docker container:

$ ./gradlew clean build
$ tar -zxvf build/distributions/besu-21.10.0-RC1-SNAPSHOT.tar.gz -C build/distributions
$ docker run -v `pwd`/build/distributions/besu-21.10.0-RC1-SNAPSHOT:/besu -it --rm openjdk:11 /bin/bash

# source /besu/besu.autocomplete.sh
# /besu/bin/besu -<TAB><TAB>

Changelog

  • Added CLI autocomplete scripts

atoulme
atoulme approved these changes Oct 5, 2021
View reviewed changes
Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@macfarla
Copy link
Contributor

macfarla commented Oct 6, 2021

to run without docker:

./gradlew installDist autocomplete
source build/besu.autocomplete.sh
./build/install/besu/bin/besu <TAB><TAB>

^ will give subcommand suggestions eg

➜  besu git:(issue_538) besu <TAB><TAB>
blocks      operator    password    public-key  retesteth   rlp

./build/install/besu/bin/besu --<TAB><TAB>
^ will give options suggestions

macfarla
macfarla approved these changes Oct 6, 2021
View reviewed changes
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I tried it out locally with and without docker

@macfarla
Copy link
Contributor

macfarla commented Oct 6, 2021

@diega thanks for your contribution! needs a changelog entry

@macfarla macfarla self-assigned this Oct 6, 2021
@bgravenorst bgravenorst mentioned this pull request Oct 6, 2021
Closed
@diega
Add a bash/zsh autocomplete script to distributions (hyperledger#538)
368c81f 
Signed-off-by: Diego López León <dieguitoll@gmail.com>
@diega diega requested a review from macfarla October 6, 2021 14:24
@macfarla macfarla merged commit fdd9352 into hyperledger:main Oct 7, 2021
@diega diega deleted the issue_538 branch October 7, 2021 01:08
jframe added a commit to jframe/besu that referenced this pull request Oct 12, 2021
@jframe
Squashed commit of the following:
9fda976 
commit 75b4a41
Author: Jason Frame <jasonwframe@gmail.com>
Date:   Tue Oct 12 13:47:01 2021 +1000

    add block header test case

    Signed-off-by: Jason Frame <jasonwframe@gmail.com>

commit 7d3001d
Author: Jason Frame <jasonwframe@gmail.com>
Date:   Tue Oct 12 13:31:08 2021 +1000

    undo unintentional change fixing unit test

    Signed-off-by: Jason Frame <jasonwframe@gmail.com>

commit 772a428
Author: Jason Frame <jasonwframe@gmail.com>
Date:   Tue Oct 12 13:21:56 2021 +1000

    Qbft validation selection was incorrectly being applied for non validator selection mode transitions

    Signed-off-by: Jason Frame <jasonwframe@gmail.com>

commit a30c314
Author: Antony Denyer <git@antonydenyer.co.uk>
Date:   Mon Oct 11 09:45:52 2021 +0100

    Allow Besu to host RPC endpoints via a plugin. (hyperledger#2754)

    This is a re-implementation of the initial POC done in PegaSysEng/pantheon#1909 by Danno Ferrin <danno.ferrin@gmail.com>

    * Only enable plugin rpc api when enabled on --rpc-http-api or --rpc-ws-apis
    * Only allow new rpc endpoints to be defined

    Signed-off-by: Antony Denyer <git@antonydenyer.co.uk>

commit fc687ab
Author: Simon Dudley <simon.dudley@consensys.net>
Date:   Mon Oct 11 08:18:03 2021 +0100

    Qbft RPCs should be disabled after starting with or switching to use validator contract (hyperledger#2817)

    Signed-off-by: Simon Dudley <simon.dudley@consensys.net>

commit 93013e9
Author: Usman Saleem <usman@usmans.info>
Date:   Fri Oct 8 15:51:40 2021 +1000

    Add QBFT support for evmtool (hyperledger#2807)

    * qbft support in evmtool

    Signed-off-by: Usman Saleem <usman@usmans.info>

commit 215e18c
Author: Sally MacFarlane <sally.macfarlane@consensys.net>
Date:   Fri Oct 8 12:32:52 2021 +1000

    master.svg -> main.svg (hyperledger#2864)

    Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

commit 82ecef6
Author: Sally MacFarlane <sally.macfarlane@consensys.net>
Date:   Fri Oct 8 11:13:11 2021 +1000

    Fixed build badge (hyperledger#2863)

    * typos

    Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

    * master -> main

    Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

commit 5fbf0b1
Author: Sally MacFarlane <sally.macfarlane@consensys.net>
Date:   Thu Oct 7 19:22:47 2021 +1000

    changed to trace level logging (hyperledger#2858)

    Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

commit fdd9352
Author: Diego López León <dieguitoll@gmail.com>
Date:   Wed Oct 6 21:51:33 2021 -0300

    Add a bash/zsh autocomplete script to distributions (hyperledger#538) (hyperledger#2854)

    Signed-off-by: Diego López León <dieguitoll@gmail.com>
jflo pushed a commit to jflo/besu that referenced this pull request Oct 14, 2021
@diega @jflo
Add a bash/zsh autocomplete script to distributions (hyperledger#538) (…
a1f1004 
…hyperledger#2854)

Signed-off-by: Diego López León <dieguitoll@gmail.com>
jflo pushed a commit to jflo/besu that referenced this pull request Oct 14, 2021
@diega @jflo
Add a bash/zsh autocomplete script to distributions (hyperledger#538) (…
243c6c1 
…hyperledger#2854)

Signed-off-by: Diego López León <dieguitoll@gmail.com>
Signed-off-by: Justin Florentine <justin.florentine@consensys.net>
@diega diega added the mainnet label May 29, 2022
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
@diega @eum602
Add a bash/zsh autocomplete script to distributions (hyperledger#538) (…
8956dab 
…hyperledger#2854)

Signed-off-by: Diego López León <dieguitoll@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atoulme atoulme atoulme approved these changes

@macfarla macfarla Awaiting requested review from macfarla

Assignees

@macfarla macfarla

Labels
mainnet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for tab completion in the CLI
3 participants
@diega @macfarla @atoulme