Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for PKCS11 keystore on PKI Block Creation #2865

Merged
merged 6 commits into from
Oct 12, 2021

Conversation

lucassaldanha
Copy link
Member

PR description

  • Extracted nested KeyStoreWrapperProvider interface into its own file
  • Created a default implementation of this interface that takes care of instantiating the correct KeyStoreWrapper based on the type configuration.

Fixed Issue(s)

fixes #2764

Changelog

@lucassaldanha lucassaldanha self-assigned this Oct 8, 2021
@@ -0,0 +1,73 @@
/*
* Copyright ConsenSys AG.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

License copyright is now meant to be "Copyright Hyperledger Besu Contributors." https://wiki.hyperledger.org/display/TSC/Copyright+and+License+Policy

Signed-off-by: Lucas Saldanha <lucascrsaldanha@gmail.com>
Signed-off-by: Lucas Saldanha <lucascrsaldanha@gmail.com>
Signed-off-by: Lucas Saldanha <lucascrsaldanha@gmail.com>
Signed-off-by: Lucas Saldanha <lucascrsaldanha@gmail.com>
Signed-off-by: Lucas Saldanha <lucascrsaldanha@gmail.com>
Signed-off-by: Lucas Saldanha <lucascrsaldanha@gmail.com>
Copy link
Contributor

@jframe jframe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucassaldanha lucassaldanha enabled auto-merge (squash) October 12, 2021 01:47
@lucassaldanha lucassaldanha merged commit bbff3c8 into hyperledger:main Oct 12, 2021
@lucassaldanha lucassaldanha deleted the besu-2764 branch October 12, 2021 02:20
jflo pushed a commit to jflo/besu that referenced this pull request Oct 14, 2021
…2865)

* Added support for PKCS11 keystore on PKI Block Creation

Signed-off-by: Lucas Saldanha <lucascrsaldanha@gmail.com>
jflo pushed a commit to jflo/besu that referenced this pull request Oct 14, 2021
…2865)

* Added support for PKCS11 keystore on PKI Block Creation

Signed-off-by: Lucas Saldanha <lucascrsaldanha@gmail.com>
Signed-off-by: Justin Florentine <justin.florentine@consensys.net>
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
…2865)

* Added support for PKCS11 keystore on PKI Block Creation

Signed-off-by: Lucas Saldanha <lucascrsaldanha@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PKCS11 hardware keystore for CMS signing
2 participants