Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build arm64 besu docker images #2954

Merged
merged 21 commits into from May 9, 2022

Conversation

garyschulte
Copy link
Contributor

@garyschulte garyschulte commented Oct 26, 2021

PR description

  • Add arm64 docker image building
  • add arch suffix to docker image publishing
  • add manifest task to create a unified docker manifest (arm64 and amd64) image publishing

Fixed Issue(s)

Changelog

.circleci/config.yml Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@garyschulte garyschulte changed the title Build arm64 besu docker images Build arm64 besu docker images [WIP] Oct 27, 2021
@ajsutton
Copy link
Contributor

For the record, with Teku I wound up needing to use a machine executor and buildx to create the multi-arch docker image correctly. I don't think I ever found a way to get an ARM docker executor in CircleCI (I could get an arm container but the remote docker attached to it was still x86). Consensys/teku#4632 is the PR for Teku.

@macfarla
Copy link
Contributor

@garyschulte - is this one superseded by #3481

@fab-10 fab-10 mentioned this pull request Apr 29, 2022
1 task
@garyschulte garyschulte reopened this May 4, 2022
@garyschulte garyschulte force-pushed the feature/arm64-docker branch 5 times, most recently from 30c693a to 51aca0d Compare May 6, 2022 08:09
@garyschulte garyschulte changed the title Build arm64 besu docker images [WIP] Build arm64 besu docker images May 6, 2022
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@fab-10 fab-10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a CHANGELOG entry for this will be nice

Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree a changelog entry would be good, otherwise LGTM

Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
@garyschulte garyschulte enabled auto-merge (squash) May 9, 2022 17:31
@garyschulte garyschulte merged commit 1efe1f0 into hyperledger:main May 9, 2022
@sonarcloud
Copy link

sonarcloud bot commented May 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@garyschulte garyschulte deleted the feature/arm64-docker branch August 3, 2022 23:19
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
* first pass at building arm64 besu docker images
* add arch to docker publish
* add architecture envars to executors
* first pass at manifest docker
* setup docker in manifest step
* add base image to manifestDocker
* add changelog

Signed-off-by: garyschulte <garyschulte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants