Fix dns discovery issue #3033
Merged
Fix dns discovery issue #3033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
garyschulte
reviewed
Nov 10, 2021
ethereum/p2p/src/main/java/org/hyperledger/besu/ethereum/p2p/network/DefaultP2PNetwork.java
Outdated
Show resolved
Hide resolved
garyschulte
requested changes
Nov 10, 2021
There was a problem hiding this comment.
great find. I think given the changes in Diego's PR #2944, we should add a test.
ethereum/p2p/src/main/java/org/hyperledger/besu/ethereum/p2p/network/DefaultP2PNetwork.java
Outdated
Show resolved
Hide resolved
…l configured Signed-off-by: garyschulte <garyschulte@gmail.com>
garyschulte
approved these changes
Nov 10, 2021
|
Kudos, SonarCloud Quality Gate passed! |
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Nov 16, 2021
We are creating but not starting the dns discovery daemon. After this modification the node find peers instantly Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Co-authored-by: garyschulte <garyschulte@gmail.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
We are creating but not starting the dns discovery daemon. After this modification the node find peers instantly Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Co-authored-by: garyschulte <garyschulte@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Karim TAAM karim.t2am@gmail.com
PR description
We are creating but not starting the dns discovery daemon. After this modification the node find peers instantly.
Fixed Issue(s)
Changelog