Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graphql - allow matching any topic #3662

Merged
merged 14 commits into from
May 6, 2022
Merged

Graphql - allow matching any topic #3662

merged 14 commits into from
May 6, 2022

Conversation

macfarla
Copy link
Contributor

@macfarla macfarla commented Mar 31, 2022 •
edited
Loading

Update GraphQL code to handle the case of empty list [] passed in as a topic

  • added test file with empty list topic [] in filter to match any topic

Fixes #3519

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if
    updates are required.

Changelog

@macfarla
added test file to match any topic
0bea51a 
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
@macfarla
allow creation of LogTopic from null
c34f7b2 
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
@macfarla
added test file
0e6bccc 
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
@macfarla
allow null topics in filters, which match any topic
03ea490 
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
@macfarla
added changelog
eaa2eff 
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
@macfarla
merge changelog
dcdb9ed 
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
@sonarcloud
Copy link

sonarcloud bot commented Mar 31, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@macfarla macfarla marked this pull request as draft April 5, 2022 01:56
@macfarla
merge main
b43c2d5 
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
@macfarla
add singleton list containing null if empty topic passed in
caaaedd 
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
@macfarla
Merge branch 'main' of github.com:hyperledger/besu into graphql-match…
09fbd4f 
…-any-topic
@macfarla macfarla changed the title Graphql - allow null topic Graphql - allow matching any topic May 4, 2022
@macfarla
merge
b17bf19 
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
@macfarla macfarla marked this pull request as ready for review May 4, 2022 11:56
shemnon
shemnon approved these changes May 6, 2022
View reviewed changes
Copy link
Contributor

@shemnon shemnon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

90 lines of test for 14 lines of code. Sounds about right.

@macfarla
revert text in schema
e5493f6 
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
@macfarla
revert null LogTopic. not needed
9a2db01 
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
@macfarla
merge
76684ad 
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
@macfarla
Merge branch 'main' into graphql-match-any-topic
c720837
@macfarla macfarla enabled auto-merge (squash) May 6, 2022 07:02
pinges
pinges approved these changes May 6, 2022
View reviewed changes
Copy link
Contributor

@pinges pinges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented May 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

50.0% 50.0% Coverage
66.7% 66.7% Duplication

@macfarla macfarla merged commit e8407ae into hyperledger:main May 6, 2022
@macfarla macfarla deleted the graphql-match-any-topic branch May 12, 2022 00:56
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
@macfarla @eum602
Graphql - allow matching any topic (hyperledger#3662)
f805c4f 
* added test file to match any topic

* add singleton list containing null if empty topic passed in

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@earizon earizon earizon left review comments

@shemnon shemnon shemnon approved these changes

@pinges pinges pinges approved these changes

Assignees
No one assigned
Labels
mainnet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GraphQL FilterCriteria does not work well filtering topics
4 participants
@macfarla @shemnon @earizon @pinges