Rename SHA3 -> Keccak256 #3749
Merged
Rename SHA3 -> Keccak256 #3749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ethereum doesn't do "offcial" sha3, we do keccak256. Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
|
Kudos, SonarCloud Quality Gate passed! |
macfarla
reviewed
Apr 22, 2022
| @@ -7,6 +7,9 @@ | |||
|
|
|||
| ## 22.4.0-RC2 | |||
|
|
|||
| ### Breaking Changes | |||
| - In the Besu EVM Library all references to SHA3 have been renamed to the more accurate name Kecack256, including class names and comment. [#3749](https://github.com/hyperledger/besu/pull/3749) | |||
macfarla
approved these changes
Apr 22, 2022
garyschulte
pushed a commit
to garyschulte/besu
that referenced
this pull request
May 2, 2022
Rename SHA3 -> Keccak256 Ethereum doesn't do "official" sha3, we do keccak256, so rename as needed to reflect that reality. Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
Rename SHA3 -> Keccak256 Ethereum doesn't do "official" sha3, we do keccak256, so rename as needed to reflect that reality. Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ethereum doesn't do "offcial" sha3, we do keccak256.
Signed-off-by: Danno Ferrin danno.ferrin@gmail.com
PR description
Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog