Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to backward sync to request headers back to last finalized block if present or genesis #3888

Merged

Conversation

fab-10
Copy link
Contributor

@fab-10 fab-10 commented May 23, 2022

Signed-off-by: Fabio Di Fabio fabio.difabio@consensys.net

PR description

Remove the limit that prevents Backward sync to download headers for block with height less than current head block height, that prevents some reorgs to happen

Fixed Issue(s)

fixes #3887

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if
    updates are required.

Changelog

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10 fab-10 requested a review from gezero May 23, 2022 15:16
@fab-10 fab-10 added the mainnet label May 23, 2022
@fab-10 fab-10 changed the title Allow to backward sync to request headers back to genesis Allow to backward sync to request headers back to last finalized block if present or genesis May 23, 2022
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10 fab-10 force-pushed the backward-sync-req-headers-till-genesis branch from 3c35db7 to 957a8fc Compare May 23, 2022 16:18
@fab-10 fab-10 marked this pull request as ready for review May 24, 2022 08:30
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Copy link
Contributor

@matkt matkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just small comment

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@sonarcloud
Copy link

sonarcloud bot commented May 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@gezero gezero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fab-10 fab-10 merged commit 80c8017 into hyperledger:main May 24, 2022
@fab-10 fab-10 deleted the backward-sync-req-headers-till-genesis branch May 24, 2022 14:43
sharad-develop pushed a commit to sharad-develop/besu that referenced this pull request May 27, 2022
…k if present or genesis (hyperledger#3888)

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Sharad Gulati <sharad.develop@gmail.com>
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
…k if present or genesis (hyperledger#3888)

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Two Block Post-PoS Re-org to Higher-Height PoW Chain fails
3 participants