-
Notifications
You must be signed in to change notification settings - Fork 759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to backward sync to request headers back to last finalized block if present or genesis #3888
Merged
fab-10
merged 5 commits into
hyperledger:main
from
fab-10:backward-sync-req-headers-till-genesis
May 24, 2022
Merged
Allow to backward sync to request headers back to last finalized block if present or genesis #3888
fab-10
merged 5 commits into
hyperledger:main
from
fab-10:backward-sync-req-headers-till-genesis
May 24, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
3c35db7
to
957a8fc
Compare
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
matkt
approved these changes
May 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just small comment
.../eth/src/main/java/org/hyperledger/besu/ethereum/eth/sync/backwardsync/BackwardSyncStep.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Kudos, SonarCloud Quality Gate passed! |
gezero
approved these changes
May 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
sharad-develop
pushed a commit
to sharad-develop/besu
that referenced
this pull request
May 27, 2022
…k if present or genesis (hyperledger#3888) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Sharad Gulati <sharad.develop@gmail.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
…k if present or genesis (hyperledger#3888) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Fabio Di Fabio fabio.difabio@consensys.net
PR description
Remove the limit that prevents Backward sync to download headers for block with height less than current head block height, that prevents some reorgs to happen
Fixed Issue(s)
fixes #3887
Documentation
doc-change-required
label to this PR ifupdates are required.
Changelog