Return transaction type for legacy transactions #4027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
antonydenyer
approved these changes
Jun 28, 2022
macfarla
approved these changes
Jun 28, 2022
plugin-api/src/main/java/org/hyperledger/besu/plugin/data/TransactionType.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
daniellehrner
deleted the
4025-add-type-when-serializing-legacy-transactions
branch
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
* return transaction type for legacy transactions Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel Lehrner daniel.lehrner@consensys.net
PR description
Instead of omitting the transaction type when serializing a legacy transaction, we return the spec conform value of
0x0.Fixed Issue(s)
fixes #4025
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog