Ignore 2 tests that assume that the system language is English, if that should not be the case #4102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at should not be the case Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
daniellehrner
changed the title
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
daniellehrner
added
the
dev experience
|
instead of ignoring, could be an option to force the tests to run with the english locale? |
fab-10
approved these changes
Jul 14, 2022
codyborn
pushed a commit
to codyborn/besu
that referenced
this pull request
Jul 31, 2022
…at should not be the case (hyperledger#4102) * ignore 2 tests that assume that the system language is English, if that should not be the case Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
codyborn
pushed a commit
to codyborn/besu
that referenced
this pull request
Jul 31, 2022
…at should not be the case (hyperledger#4102) * ignore 2 tests that assume that the system language is English, if that should not be the case Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> Signed-off-by: Cody Born <codyborn@outlook.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
…at should not be the case (hyperledger#4102) * ignore 2 tests that assume that the system language is English, if that should not be the case Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel Lehrner daniel.lehrner@consensys.net
PR description
2 of our tests that check error messages from the JVM assume that the system language is always English. If that is not the case, the JVM error messages will be localized and the tests will fail. This PR checks the system language before running those 2 tests and ignores them, if it is not English. If the system language is English the tests are executed like before.
Fixed Issue(s)
fixes #2190
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog