post-merge sync and peering fix #4116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
jflo
approved these changes
Jul 18, 2022
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
* add a merge-specific definiton of bestPeer and the supporting plumbing Signed-off-by: garyschulte <garyschulte@gmail.com> * set reached TTD when finishing a fast sync if appropriate Signed-off-by: garyschulte <garyschulte@gmail.com> * spdx header Signed-off-by: garyschulte <garyschulte@gmail.com> * fix BetterSyncTargetEvaluatorTest tests Signed-off-by: garyschulte <garyschulte@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
addresses two sources of problems when syncing a post-merge network:
adds a merge-specific 'best peer' comparator rather than the PoW heaviest chain comparator. This resolves a bug where besu would order its peers incorrectly and report that it did not have any peers with sufficient chain height:
No sync target with sufficient chain height, waiting for peers: {}ensures 'fast' syncs (snap, checkpoint, fast) set the syncState as having reached TTD to satisfy preconditions for backward sync capability. This fixes a 'stuck' issue where a fast sync would complete and catch up to a post-merge finalized block, but backward sync was not able to backfill from head back to the finalized block, and besu would just sit at its final fast sync pivot block.
Fixed Issue(s)
#3956
#3329
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog