Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for fast sync regression on post-merge networks #4224

Merged
merged 2 commits into from
Aug 9, 2022
Merged

fix for fast sync regression on post-merge networks #4224

merged 2 commits into from
Aug 9, 2022

Conversation

garyschulte
Copy link
Contributor

@garyschulte garyschulte commented Aug 5, 2022 •
edited
Loading

PR description

  • re-enable PoW, Timestamp, and Difficulty block header validation rules regardless of merge configuration.
  • if merge is enabled, use an AttachedBlockHeaderValidationRule version of ProofOfWorkValidationRule

Fixed Issue(s)

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if
    updates are required.

Changelog

@non-fungible-nelson non-fungible-nelson added the TeamChupa GH issues worked on by Chupacabara Team label Aug 8, 2022
@garyschulte
use attached/detached rule difference to prevent PoW rules from influ…
ea8a6c9 
…encing fast sync around TTD

Signed-off-by: garyschulte <garyschulte@gmail.com>
@garyschulte garyschulte marked this pull request as ready for review August 9, 2022 20:51
@garyschulte
add spdx header
5734cf1 
Signed-off-by: garyschulte <garyschulte@gmail.com>
jflo
jflo approved these changes Aug 9, 2022
View reviewed changes
Copy link
Contributor

@jflo jflo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL about attached rules

@garyschulte garyschulte merged commit bd9b98c into hyperledger:main Aug 9, 2022
@garyschulte garyschulte deleted the bugfix/4190-regression branch August 9, 2022 23:31
@garyschulte garyschulte mentioned this pull request Aug 10, 2022
Closed
2 tasks
@garyschulte garyschulte mentioned this pull request Aug 17, 2022
Merged
2 tasks
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
@garyschulte @eum602
fix for fast sync regression on post-merge networks (hyperledger#4224)
2074338 
* use attached/detached rule difference to prevent PoW rules from influencing fast sync around TTD

Signed-off-by: garyschulte <garyschulte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jflo jflo jflo approved these changes

Assignees
No one assigned
Labels
TeamChupa GH issues worked on by Chupacabara Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@garyschulte @jflo @non-fungible-nelson