Avoid a cyclic reference while printing EngineExchangeTransitionConfigurationParameter #4357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…igurationParameter Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
fab-10
requested changes
Sep 9, 2022
...ethereum/api/jsonrpc/internal/parameters/EngineExchangeTransitionConfigurationParameter.java
Outdated
Show resolved
Hide resolved
…ameter_cyclic_ref
…ameter_cyclic_ref
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
fab-10
approved these changes
Oct 11, 2022
…ameter_cyclic_ref
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
…ameter_cyclic_ref
daniellehrner
deleted the
fix_EngineExchangeTransitionConfigurationParameter_cyclic_ref
branch
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
…gurationParameter (hyperledger#4357) * avoids a cyclic reference while printing EngineExchangeTransitionConfigurationParameter Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel Lehrner daniel.lehrner@consensys.net
PR description
EngineExchangeTransitionConfigurationParameter is printed if logging is set to
TRACE. In the current version it throws an exception while trying to print it, because of a circular reference. This PR avoids this circular reference and EngineExchangeTransitionConfigurationParameter is printed as expected.Fixed Issue(s)
fixes #4354
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog