New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PIE-2284] Add trace transaction api #441
Merged
AbdelStark
merged 9 commits into
hyperledger:master
from
matkt:feature/pie-2284-add-trace-transaction-api
Mar 9, 2020
Merged
[PIE-2284] Add trace transaction api #441
AbdelStark
merged 9 commits into
hyperledger:master
from
matkt:feature/pie-2284-add-trace-transaction-api
Mar 9, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
…d and not its value because it is different each time generateTestBlockchain is called Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
…pie-2284-add-trace-transaction-api Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
…nger generate it during the build. adding the nonce to the blocks.json file should solve this problem Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
matkt
force-pushed
the
feature/pie-2284-add-trace-transaction-api
branch
from
March 6, 2020 10:36
d9157ea
to
6327f5a
Compare
…pie-2284-add-trace-transaction-api Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
AbdelStark
approved these changes
Mar 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
PIE 2284 : https://pegasys1.atlassian.net/browse/PIE-2284
We should expose an equivalent to Parity's trace_transaction API (https://wiki.parity.io/JSONRPC-trace-module.html#trace_transaction). Most of this work should have already been done as part of the previous tracing APIs implemented. This task involves exposing an additional API that will take a transaction hash and provide its trace, and making sure the output is compatible with Parity's.
Acceptance Criteria