Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PIE-2284] Add trace transaction api #441

Conversation

matkt
Copy link
Contributor

@matkt matkt commented Mar 5, 2020

PR description

PIE 2284 : https://pegasys1.atlassian.net/browse/PIE-2284

We should expose an equivalent to Parity's trace_transaction API (https://wiki.parity.io/JSONRPC-trace-module.html#trace_transaction). Most of this work should have already been done as part of the previous tracing APIs implemented. This task involves exposing an additional API that will take a transaction hash and provide its trace, and making sure the output is compatible with Parity's.

Acceptance Criteria

  • Equivalent API to Parity's trace_transaction

Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
…d and not its value because it is different each time generateTestBlockchain is called

Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
…pie-2284-add-trace-transaction-api

Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
…nger generate it during the build. adding the nonce to the blocks.json file should solve this problem

Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
@matkt matkt force-pushed the feature/pie-2284-add-trace-transaction-api branch from d9157ea to 6327f5a Compare March 6, 2020 10:36
…pie-2284-add-trace-transaction-api

Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Copy link
Contributor

@AbdelStark AbdelStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@AbdelStark AbdelStark merged commit 67a0c79 into hyperledger:master Mar 9, 2020
@matkt matkt mentioned this pull request Mar 12, 2020
@matkt matkt deleted the feature/pie-2284-add-trace-transaction-api branch April 8, 2020 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants