Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config file support for high spec flag #4438

Merged

Conversation

ahamlat
Copy link
Contributor

@ahamlat ahamlat commented Sep 25, 2022

PR description

With PR #4423, the flag --Xplugin-rocksdb-high-spec-enabled doesn't work with Toml configuration files. This PR fix this issue.

Fixed Issue(s)

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if
    updates are required.

Changelog

ahamlat and others added 5 commits September 22, 2022 11:39
…r high spec hardware to boost performance.

Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net>
…r high spec hardware to boost performance.

Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net>
…r high spec hardware to boost performance.

Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net>
…igh-spec-enabled

Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10
Copy link
Contributor

fab-10 commented Sep 26, 2022

Please update also the CHANGELOG with this fix

…ag --Xplugin-rocksdb-high-spec-enabled

Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net>
…pec-flag' into add-support-toml-conf-for-high-spec-flag
@ahamlat
Copy link
Contributor Author

ahamlat commented Sep 26, 2022

Please update also the CHANGELOG with this fix

Done.

@fab-10 fab-10 merged commit d6e1400 into hyperledger:main Sep 26, 2022
inDane added a commit to inDane/besu that referenced this pull request Sep 27, 2022
hyperledger#4438 


Signed-off-by: inDane <inDane@users.noreply.github.com>
@inDane inDane mentioned this pull request Sep 27, 2022
2 tasks
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants