Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC parameter error improvements. Test updates. #4510

Merged
merged 5 commits into from
Oct 11, 2022

Conversation

mark-terry
Copy link
Contributor

@mark-terry mark-terry commented Oct 10, 2022

Signed-off-by: mark-terry mark.terry@consensys.net

PR description

Increase level of detail in RPC parameter error logging to improve usability.

Fixed Issue(s)

Fixes #4326

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if
    updates are required.

Changelog

mark-terry and others added 3 commits October 10, 2022 22:39
Signed-off-by: mark-terry <mark.terry@consensys.net>
Signed-off-by: mark-terry <mark.terry@consensys.net>
Signed-off-by: mark-terry <mark.terry@consensys.net>
@mark-terry mark-terry requested a review from jflo October 10, 2022 14:20
@mark-terry mark-terry self-assigned this Oct 10, 2022
@mark-terry mark-terry added TeamRevenant GH issues worked on by Revenant Team RPC logging labels Oct 10, 2022
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mark-terry mark-terry merged commit 7a2db24 into hyperledger:main Oct 11, 2022
@mark-terry mark-terry deleted the rpc_log_improvements branch October 11, 2022 03:48
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
* RPC parameter error improvements. Test updates.

Signed-off-by: mark-terry <mark.terry@consensys.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
logging mainnet RPC TeamRevenant GH issues worked on by Revenant Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve logging when RPC parameters are missing or empty
2 participants