Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PoS block creation max time a config option #4519

Merged
merged 6 commits into from
Oct 12, 2022

Conversation

fab-10
Copy link
Contributor

@fab-10 fab-10 commented Oct 11, 2022

Signed-off-by: Fabio Di Fabio fabio.difabio@consensys.net

PR description

New early access configuration options to set the maximum time, in milliseconds, a PoS block creation jobs is allowed to run.

Fixed Issue(s)

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if
    updates are required.

Changelog

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10 fab-10 force-pushed the pos-block-creation-max-time-options branch from aa79c6c to b327d55 Compare October 11, 2022 12:25
@fab-10 fab-10 added the mainnet label Oct 11, 2022
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10 fab-10 marked this pull request as ready for review October 11, 2022 15:13
Copy link
Contributor

@garyschulte garyschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. At some point we should consider changing MiningParameters to BlockBuilderParameters or something that is not PoW specific.

@fab-10 fab-10 merged commit 33a0188 into hyperledger:main Oct 12, 2022
@fab-10 fab-10 deleted the pos-block-creation-max-time-options branch October 12, 2022 09:43
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants