Fix storage key format for eth_getProof #4564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@consensys.net>
Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@consensys.net>
…://github.com/Gabriel-Trintinalia/besu into 4504-storage-proof-do-not-remove-leading-zero
macfarla
reviewed
Oct 27, 2022
...src/test/resources/org/hyperledger/besu/ethereum/api/jsonrpc/eth/eth_getProof_blockHash.json
Outdated
Show resolved
Hide resolved
shemnon
reviewed
Oct 27, 2022
...java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/results/proof/StorageEntryProof.java
Outdated
Show resolved
Hide resolved
shemnon
reviewed
Oct 27, 2022
...rc/test/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/EthGetProofTest.java
Outdated
Show resolved
Hide resolved
…sonrpc/internal/results/proof/StorageEntryProof.java Co-authored-by: Danno Ferrin <danno.ferrin@shemnon.com> Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
…sonrpc/internal/methods/EthGetProofTest.java Co-authored-by: Danno Ferrin <danno.ferrin@shemnon.com> Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Gabriel-Trintinalia
changed the title
Gabriel-Trintinalia
changed the title
Gabriel-Trintinalia
changed the title
Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com>
Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com>
Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com>
|
Following eip-1474 spec |
Gabriel-Trintinalia
changed the title
Gabriel-Trintinalia
changed the title
shemnon
reviewed
Dec 6, 2022
| @@ -20,7 +20,7 @@ | |||
| "nonce" : "0x0", | |||
| "storageHash" : "0x56e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421", | |||
| "storageProof" : [ { | |||
| "key" : "0x347", | |||
| "key" : "0x0347", | |||
There was a problem hiding this comment.
Aligns with execution APIs (no odd-length hex)
https://github.com/ethereum/execution-apis/blob/main/src/schemas/state.yaml#L48
https://github.com/ethereum/execution-apis/blob/main/src/schemas/base-types.yaml#L22-L25
shemnon
approved these changes
Dec 6, 2022
Gabriel-Trintinalia
added a commit
to Gabriel-Trintinalia/besu
that referenced
this pull request
Dec 8, 2022
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Gabriel-Trintinalia
deleted the
4504-storage-proof-do-not-remove-leading-zero
branch
ahamlat
pushed a commit
to ahamlat/besu
that referenced
this pull request
Dec 18, 2022
Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net>
macfarla
pushed a commit
to macfarla/besu
that referenced
this pull request
Jan 10, 2023
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
This was referenced May 19, 2023
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gabriel Trintinalia gabriel.trintinalia@consensys.net
PR description
Follow EIP-1474 spec - each byte must be represented using two hex digits
Fixed Issue(s)
fixes #4504
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog