-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added max range CLI option for eth_getLogs. #4597
Conversation
Signed-off-by: mark-terry <mark.terry@consensys.net>
Signed-off-by: mark-terry <mark.terry@consensys.net>
Signed-off-by: mark-terry <mark.terry@consensys.net>
Signed-off-by: mark-terry <mark.terry@consensys.net>
Signed-off-by: mark-terry <mark.terry@consensys.net>
ethereum/api/src/main/java/org/hyperledger/besu/ethereum/api/query/BlockchainQueries.java
Outdated
Show resolved
Hide resolved
Signed-off-by: mark-terry <mark.terry@consensys.net>
Signed-off-by: mark-terry <mark.terry@consensys.net>
Signed-off-by: mark-terry <36909937+mark-terry@users.noreply.github.com>
Signed-off-by: mark-terry <mark.terry@consensys.net>
Signed-off-by: mark-terry <mark.terry@consensys.net>
Signed-off-by: mark-terry <mark.terry@consensys.net>
Signed-off-by: mark-terry <mark.terry@consensys.net>
Signed-off-by: mark-terry <36909937+mark-terry@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: mark-terry <mark.terry@consensys.net>
Some data on eth_getLogs output from Mainnet: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mark-terry you'll need to move the changelog entry to 22.10.2
Signed-off-by: mark-terry <mark.terry@consensys.net>
* Added max range CLI option for eth_getLogs. Default value: 1000. Signed-off-by: mark-terry <mark.terry@consensys.net> Signed-off-by: mark-terry <36909937+mark-terry@users.noreply.github.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
* Added max range CLI option for eth_getLogs. Default value: 1000. Signed-off-by: mark-terry <mark.terry@consensys.net> Signed-off-by: mark-terry <36909937+mark-terry@users.noreply.github.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nur
* Added max range CLI option for eth_getLogs. Default value: 1000. Signed-off-by: mark-terry <mark.terry@consensys.net> Signed-off-by: mark-terry <36909937+mark-terry@users.noreply.github.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: mark-terry mark.terry@consensys.net
PR description
Adds a
--rpc-max-logs-range
CLI option to restrict the maximum block range to query foreth_getLogs
.Fixed Issue(s)
Adds suggestion from #4123
Documentation
doc-change-required
label to this PR ifupdates are required.
Changelog