Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added max range CLI option for eth_getLogs. #4597

Merged
merged 27 commits into from
Dec 5, 2022

Conversation

mark-terry
Copy link
Contributor

@mark-terry mark-terry commented Nov 3, 2022

Signed-off-by: mark-terry mark.terry@consensys.net

PR description

Adds a --rpc-max-logs-range CLI option to restrict the maximum block range to query for eth_getLogs.

Fixed Issue(s)

Adds suggestion from #4123

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if
    updates are required.

Changelog

mark-terry and others added 7 commits November 3, 2022 10:20
Signed-off-by: mark-terry <mark.terry@consensys.net>
Signed-off-by: mark-terry <mark.terry@consensys.net>
Signed-off-by: mark-terry <mark.terry@consensys.net>
Signed-off-by: mark-terry <mark.terry@consensys.net>
Signed-off-by: mark-terry <mark.terry@consensys.net>
Signed-off-by: mark-terry <mark.terry@consensys.net>
mark-terry and others added 5 commits November 7, 2022 11:33
Signed-off-by: mark-terry <mark.terry@consensys.net>
Signed-off-by: mark-terry <mark.terry@consensys.net>
Signed-off-by: mark-terry <mark.terry@consensys.net>
Signed-off-by: mark-terry <mark.terry@consensys.net>
@mark-terry mark-terry changed the title Added max range CLI option for eth_getLogs. Added max range CLI option for eth_getLogs and priv_getLogs. Nov 7, 2022
mark-terry and others added 6 commits November 7, 2022 20:50
Signed-off-by: mark-terry <mark.terry@consensys.net>
Signed-off-by: mark-terry <36909937+mark-terry@users.noreply.github.com>
Signed-off-by: mark-terry <mark.terry@consensys.net>
Signed-off-by: mark-terry <mark.terry@consensys.net>
@mark-terry mark-terry changed the title Added max range CLI option for eth_getLogs and priv_getLogs. Added max range CLI option for eth_getLogs. Nov 8, 2022
Signed-off-by: mark-terry <mark.terry@consensys.net>
@mark-terry mark-terry marked this pull request as ready for review November 8, 2022 14:32
@mark-terry mark-terry self-assigned this Nov 8, 2022
@mark-terry mark-terry added doc-change-required Indicates an issue or PR that requires doc to be updated RPC labels Nov 8, 2022
mark-terry and others added 2 commits November 29, 2022 23:10
Signed-off-by: mark-terry <mark.terry@consensys.net>
Signed-off-by: mark-terry <36909937+mark-terry@users.noreply.github.com>
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mark-terry and others added 2 commits December 1, 2022 13:09
Signed-off-by: mark-terry <mark.terry@consensys.net>
@mark-terry
Copy link
Contributor Author

Some data on eth_getLogs output from Mainnet:
1000 block range: ~200Mb output, ~1s processing time
2000 block range: ~400Mb output, ~1.2s processing time
5000 block range: ~1.2Gb output, ~4.5s processing time.

Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mark-terry you'll need to move the changelog entry to 22.10.2

mark-terry and others added 2 commits December 4, 2022 20:37
Signed-off-by: mark-terry <mark.terry@consensys.net>
@mark-terry mark-terry merged commit 6973a07 into hyperledger:main Dec 5, 2022
@mark-terry mark-terry deleted the eth_getLogs_maxRange branch December 5, 2022 00:29
Gabriel-Trintinalia pushed a commit to Gabriel-Trintinalia/besu that referenced this pull request Dec 8, 2022
* Added max range CLI option for eth_getLogs. Default value: 1000.

Signed-off-by: mark-terry <mark.terry@consensys.net>
Signed-off-by: mark-terry <36909937+mark-terry@users.noreply.github.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@alexandratran alexandratran removed the doc-change-required Indicates an issue or PR that requires doc to be updated label Dec 12, 2022
macfarla added a commit to macfarla/besu that referenced this pull request Jan 10, 2023
* Added max range CLI option for eth_getLogs. Default value: 1000.

Signed-off-by: mark-terry <mark.terry@consensys.net>
Signed-off-by: mark-terry <36909937+mark-terry@users.noreply.github.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Copy link

@Nurbad01 Nurbad01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nur

@macfarla macfarla mentioned this pull request Mar 13, 2023
3 tasks
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
* Added max range CLI option for eth_getLogs. Default value: 1000.

Signed-off-by: mark-terry <mark.terry@consensys.net>
Signed-off-by: mark-terry <36909937+mark-terry@users.noreply.github.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants