Speedup modexp #4780
Merged
Speedup modexp #4780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increate the speed of ModExp gas calculations. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Use a native lib for modexp precompile. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
update native libs Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Update the acceptance test containers to be more in line with the build containers. Ubuntu 22.04, etc. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
jflo
approved these changes
Dec 7, 2022
| * | ||
| * @param a first value | ||
| * @param b second value | ||
| * @return value of a times b if no over/underflows or Long.MAX_VALUE/Long.MIN_VALUE otherwise |
There was a problem hiding this comment.
probably meant Integer in these docs.
| Bytes num; | ||
| if (offset + length <= input.size()) { | ||
| num = input.slice(offset, length).trimLeadingZeros(); | ||
| } else { |
There was a problem hiding this comment.
Suggestion: the else case behavior wouldn't be intuitive to me as a caller, might warrant a javadoc explaining that you can request more bytes back than available from your offset.
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Gabriel-Trintinalia
pushed a commit
to Gabriel-Trintinalia/besu
that referenced
this pull request
Dec 8, 2022
Increate the speed of ModExp gas calculations by using primitive types. Use a native lib for modexp precompile. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> * Native modexp Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
ahamlat
pushed a commit
to ahamlat/besu
that referenced
this pull request
Dec 18, 2022
Increate the speed of ModExp gas calculations by using primitive types. Use a native lib for modexp precompile. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> * Native modexp Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net>
macfarla
pushed a commit
to macfarla/besu
that referenced
this pull request
Jan 10, 2023
Increate the speed of ModExp gas calculations by using primitive types. Use a native lib for modexp precompile. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> * Native modexp Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
Increate the speed of ModExp gas calculations by using primitive types. Use a native lib for modexp precompile. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> * Native modexp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Speed up the gas calculation and execution of the modexp precompile.
Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog