Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RPC] add SAFE and FINALIZED options for block param #4902

Merged
merged 10 commits into from Jan 11, 2023
Merged

[RPC] add SAFE and FINALIZED options for block param #4902

merged 10 commits into from Jan 11, 2023

Conversation

macfarla
Copy link
Contributor

RPC method changes

  • add SAFE and FINALIZED options for block param
  • check length of blockNumber / blockHash param - if it's too short to be a blockHash and too long to be a blockNumber, throw Invalid params
  • added some extra tests. Specifically this file eth_getTransactionCount_invalidBlockNumber.json - without the code changes in this PR, that spec test returns "block not found", with these changes returns Invalid params

See #4233

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if
    updates are required.

Changelog

@macfarla
new test file with a block number param that is too long to be a bloc…
ef4b0eb 
…k number

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla
check for block hash parameter length
0c67f3f 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla
Merge branch 'main' of github.com:hyperledger/besu into rpc-check-blo…
ef65633 
…ck-param-length
@macfarla
Merge branch 'main' of github.com:hyperledger/besu into rpc-check-blo…
4b7d704 
…ck-param-length
@macfarla
Merge branch 'main' of github.com:hyperledger/besu into rpc-check-blo…
7bea05d 
…ck-param-length
@macfarla
added unit test for safe & finalized
0357772 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla
Merge branch 'main' of github.com:hyperledger/besu into rpc-check-blo…
5c85caf 
…ck-param-length
@macfarla
Merge branch 'main' of github.com:hyperledger/besu into rpc-check-blo…
e4a404f 
…ck-param-length
@macfarla
changelog entry
09a25b1 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla macfarla enabled auto-merge (squash) January 11, 2023 22:48
@macfarla macfarla merged commit 45c2c47 into hyperledger:main Jan 11, 2023
@macfarla macfarla deleted the rpc-check-block-param-length branch January 28, 2023 04:39
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
@macfarla @eum602
[RPC] add SAFE and FINALIZED options for block param (hyperledger#4902)
94f409c 
* new test file with a block number param that is too long to be a block number

* check for block hash parameter length

* added unit test for safe & finalized

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garyschulte garyschulte garyschulte approved these changes

Assignees
No one assigned
Labels
mainnet RPC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@macfarla @garyschulte