Add '--fork=' to EvmTool #4913
Add '--fork=' to EvmTool #4913
Conversation
Add a CLI '--fork' option to allow code to be evaluated in specific forks. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
shemnon
added
the
doc-change-required
|
docs change a new Samples: |
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
| @Override | ||
| BlockHeaderFunctions blockHashFunction() { | ||
| return new MainnetBlockHeaderFunctions(); | ||
| public static Map<String, Supplier<HeaderBasedProtocolSchedule>> createSchedules() { |
There was a problem hiding this comment.
This looks like a new place to remember to update when we create new forks. I wish we had a way of discovering these places without resorting to some kind of rigid static analysis/annotation
There was a problem hiding this comment.
The main issue here is that it crosses module barriers. EVM has configurations that need to be set up, and so does the mainnet client. Throw in if we do things like separate out the block and tx data validation that those also have different rules based on different forks.
But if we had all EVM changes come from one source that would be good. Will think about it once EOF settles down.
|
One big change I want to do with EVM tool is remove the ability to interface with a production database and move those features into another tool that can also do things like extract contract code and storage values. |
bgravenorst
removed
the
doc-change-required
* Add '--fork=' to EvmTool Add a CLI '--fork' option to allow code to be evaluated in specific forks. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
* Add '--fork=' to EvmTool Add a CLI '--fork' option to allow code to be evaluated in specific forks. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
PR description
Add a CLI '--fork' option to allow code to be evaluated in specific forks.
Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog