Add implementation for eth_createAccessList RPC method #4942

Gabriel-Trintinalia · 2023-01-16T18:22:26Z

PR description

Description

Missing implementation for eth_createAccessList rpc method

Acceptance Criteria

https://web3js.readthedocs.io/en/v1.7.0/web3-eth-contract.html#methods-mymethod-createaccesslist

This PR fixes the following failing test cases:

https://github.com/ethereum/execution-apis/tree/main/tests/eth_createAccessList
- eth_createAccessList/create-al-multiple-reads (besu)
- eth_createAccessList/create-al-simple-contract (besu)
- eth_createAccessList/create-al-simple-transfer (besu)

Expected behavior:
To return properties to be compatible with web3.

Actual behavior:

curl --data '{"method":"eth_createAccessList","params":[{"from": "0x8cd02c6cbd8375b39b06577f8d50c51d86e8d5cd", "data": "0x608060806080608155"}, "pending"],"id":1,"jsonrpc":"2.0"}' -H "Content-Type: application/json" -X POST localhost:8545
{
  "jsonrpc" : "2.0",
  "id" : 1,
  "error" : {
    "code" : -32601,
    "message" : "Method not found"
  }
}%

Fixed Issue(s)

#3400

Documentation

I thought about documentation and added the doc-change-required label to this PR if
updates are required.

Changelog

I thought about the changelog and included a changelog update if required.

Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com>

macfarla

couple of comments around naming

...ain/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/EthCreateAccessList.java

macfarla · 2023-01-17T00:15:46Z

...ain/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/EthCreateAccessList.java

+      return errorResponse(requestContext, jsonRpcError.get());
+    }
+    final AccessListSimulatorResult maybeResult =
+        maybeProcessTransaction(jsonCallParameter, blockHeader);


Trying to think of a better name. the maybe is whether the result is valid, not whether it does the processing?
simulateAccessList
simulateTransactionWithAccessList
processTransaction
and then
processTransactionWithAccessListOverride
or just processTransaction() with different params

Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com>

evm/src/main/java/org/hyperledger/besu/evm/frame/MessageFrame.java

testutil/src/main/java/org/hyperledger/besu/testutil/BlockTestUtil.java

macfarla · 2023-01-22T22:28:06Z

...ain/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/AbstractEstimateGas.java

+
+import java.util.Optional;
+
+public abstract class AbstractEstimateGas implements JsonRpcMethod {


I like the abstract class

…java Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

…Util.java Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

) * Implement method EthCreateAccessList Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com> * Add test resource file Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com> * Change changelog Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com> * fix javadoc Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com> * Invert logic and rename methods to improve readability Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com> * Introduce abstract class to improve readability Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com> * Add copyright Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com> * Update evm/src/main/java/org/hyperledger/besu/evm/frame/MessageFrame.java Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * Update testutil/src/main/java/org/hyperledger/besu/testutil/BlockTestUtil.java Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * Update testutil/src/main/java/org/hyperledger/besu/testutil/BlockTestUtil.java Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com> Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>

Gabriel-Trintinalia and others added 2 commits January 16, 2023 14:49

Implement method EthCreateAccessList

8ef5e11

Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com>

Add test resource file

d343127

Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com>

Gabriel-Trintinalia added doc-change-required Indicates an issue or PR that requires doc to be updated TeamRevenant GH issues worked on by Revenant Team mainnet RPC labels Jan 16, 2023

Gabriel-Trintinalia marked this pull request as draft January 16, 2023 18:22

Change changelog

e122d90

Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com>

Gabriel-Trintinalia mentioned this pull request Jan 16, 2023

Add implementation for eth_createAccessList RPC method #4816

Closed

2 tasks

Gabriel-Trintinalia marked this pull request as ready for review January 16, 2023 18:56

macfarla reviewed Jan 17, 2023

View reviewed changes

Gabriel-Trintinalia added 6 commits January 19, 2023 21:24

Merge main into 3400-create-access-list-clean

ccf6c85

Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com>

fix javadoc

688d814

Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com>

Merge branch 'main' into 3400-create-access-list-clean

27b32e3

Merge branch 'hyperledger:main' into 3400-create-access-list-clean

e3e7af1

Invert logic and rename methods to improve readability

aa0e471

Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com>

Introduce abstract class to improve readability

8ddbdd3

Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com>

Gabriel-Trintinalia requested a review from macfarla January 22, 2023 13:42

Add copyright

bddf56e

Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com>

macfarla approved these changes Jan 22, 2023

View reviewed changes

macfarla added 5 commits January 23, 2023 08:28

Update evm/src/main/java/org/hyperledger/besu/evm/frame/MessageFrame.…

b6a209e

…java Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

Update testutil/src/main/java/org/hyperledger/besu/testutil/BlockTest…

9b77092

…Util.java Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

Update testutil/src/main/java/org/hyperledger/besu/testutil/BlockTest…

7d4be60

…Util.java Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

Merge branch 'main' into 3400-create-access-list-clean

c7b4001

Merge branch 'main' into 3400-create-access-list-clean

b501f31

macfarla enabled auto-merge (squash) January 22, 2023 22:52

macfarla merged commit c4dbc58 into hyperledger:main Jan 22, 2023

alexandratran mentioned this pull request Feb 1, 2023

Document eth_createAccessList hyperledger/besu-docs#1257

Closed

1 task

alexandratran removed the doc-change-required Indicates an issue or PR that requires doc to be updated label Feb 1, 2023

non-fungible-nelson mentioned this pull request Feb 22, 2023

Update README.md MariusVanDerWijden/tx-fuzz#20

Merged

Gabriel-Trintinalia deleted the 3400-create-access-list-clean branch March 9, 2023 01:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add implementation for eth_createAccessList RPC method #4942

Add implementation for eth_createAccessList RPC method #4942

Gabriel-Trintinalia commented Jan 16, 2023 •

edited

macfarla left a comment

macfarla Jan 17, 2023

Gabriel-Trintinalia Jan 22, 2023

macfarla Jan 22, 2023


		import java.util.Optional;

		public abstract class AbstractEstimateGas implements JsonRpcMethod {

Add implementation for eth_createAccessList RPC method #4942

Add implementation for eth_createAccessList RPC method #4942

Conversation

Gabriel-Trintinalia commented Jan 16, 2023 • edited

PR description

Description

Acceptance Criteria

Fixed Issue(s)

Documentation

Changelog

macfarla left a comment

Choose a reason for hiding this comment

macfarla Jan 17, 2023

Choose a reason for hiding this comment

Gabriel-Trintinalia Jan 22, 2023

Choose a reason for hiding this comment

macfarla Jan 22, 2023

Choose a reason for hiding this comment

Gabriel-Trintinalia commented Jan 16, 2023 •

edited