Change param of to hexadecimal of Eth fee history to match spec #5047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
gfukushima
added
doc-change-required
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
macfarla
approved these changes
Feb 6, 2023
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
…to ethFeeHistory-spec-complaint
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Gabriel-Trintinalia
pushed a commit
to Gabriel-Trintinalia/besu
that referenced
this pull request
Feb 8, 2023
…rledger#5047) * Convert blockCount from hex to match JSON-RPC Specification Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Fix tests Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Add changelog Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> --------- Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com>
bgravenorst
removed
the
doc-change-required
ensi321
pushed a commit
to ensi321/besu
that referenced
this pull request
Feb 19, 2023
…rledger#5047) * Convert blockCount from hex to match JSON-RPC Specification Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Fix tests Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Add changelog Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> --------- Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
elenduuche
pushed a commit
to elenduuche/besu
that referenced
this pull request
Aug 16, 2023
…rledger#5047) * Convert blockCount from hex to match JSON-RPC Specification Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Fix tests Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Add changelog Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> --------- Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
…rledger#5047) * Convert blockCount from hex to match JSON-RPC Specification Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Fix tests Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Add changelog Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> --------- Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Change param type to accept hexadecimal and match the spec: https://ethereum.github.io/execution-apis/api-documentation/
Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog