Release 23.1.1 rc1 #5106

jframe · 2023-02-17T04:31:28Z

PR description

Create release for 23.1.1-RC1

Include commits from 23.1.0 -> main (ac23d31)
Update version 23.1.1-RC1
Update changelog

Fixed Issue(s)

Documentation

I thought about documentation and added the doc-change-required label to this PR if
updates are required.

Acceptance Tests (Non Mainnet)

I have considered running ./gradlew acceptanceTestNonMainnet locally if my PR affects non-mainnet modules.

Changelog

I thought about the changelog and included a changelog update if required.

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>

…ds (hyperledger#4980) * Add engine get payload body methods and test Signed-off-by: Zhenyang Shi <wcgcyx@gmail.com> Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Add header Signed-off-by: Zhenyang Shi <wcgcyx@gmail.com> * Update result struct & add test Signed-off-by: Zhenyang Shi <wcgcyx@gmail.com> * Change constant to use upper case Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Add PayloadBody class and withdrawals to response of methods Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Add unit tests Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Add changelog Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * spotless Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Add check to prevent returning trailing null results past the head Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Add test to check trailing null post head scenario Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Split tests into pre and post shanghai Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * spotless Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Rename methods Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Use getName() to log method name Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * spotless Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Rename variable Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Call constructor directly Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Fix ByHash json parsing Signed-off-by: Simon Dudley <simon.dudley@consensys.net> * Fix json parsing again Signed-off-by: Simon Dudley <simon.dudley@consensys.net> * Add check to prevent unnecessary queries Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Refactor method Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Add new error code for EngineGetPayloadBodies methods Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Add return error for request above the API limit Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Add constructor for empty response Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * add check for number of blocks requested and for requests of post head Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Add test to check error code when request exceeds API limits Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * add constant for max blocks allowed per request Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * spotless Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Fix some nits Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Add invalid params check Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Add tests for invalid params check Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Fix test and spotless Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Revert "Fix json parsing again" This reverts commit 558d325. Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Revert "Fix ByHash json parsing Signed-off-by: Simon Dudley <simon.dudley@consensys.net>" This reverts commit 663e11e Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Use UnsignedLongParameter to cast params of the request Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Add optional withdrawals to the NewPayload log (hyperledger#5021) Signed-off-by: Simon Dudley <simon.dudley@consensys.net> * kubernetes and errorprone - update versions (hyperledger#5013) * update errorprone and kubernetes versions * fixed errorprone issues in prod cod * fixed errorprone issues in test code --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * Rename JsonRpcService to EngineJsonRpcService (hyperledger#5036) * rename JsonRpcService to EngineJsonRpcService Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Params should be single item of array type, not outer array of strings (hyperledger#5037) Signed-off-by: Simon Dudley <simon.dudley@consensys.net> * Add EIP-2537 (BLS12-381 curve precompiles) to Cancun (hyperledger#5017) Add the BLS curve precompiles into the registry for cancun. All of the curve precompiles have been here since berlin, so this is just wiring them in. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> * Use UnsignedLongParameter to cast params of the request Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Add optional withdrawals to the NewPayload log (hyperledger#5021) Signed-off-by: Simon Dudley <simon.dudley@consensys.net> * kubernetes and errorprone - update versions (hyperledger#5013) * update errorprone and kubernetes versions * fixed errorprone issues in prod cod * fixed errorprone issues in test code --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * Rename JsonRpcService to EngineJsonRpcService (hyperledger#5036) * rename JsonRpcService to EngineJsonRpcService Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * Params should be single item of array type, not outer array of strings (hyperledger#5037) Signed-off-by: Simon Dudley <simon.dudley@consensys.net> * Add EIP-2537 (BLS12-381 curve precompiles) to Cancun (hyperledger#5017) Add the BLS curve precompiles into the registry for cancun. All of the curve precompiles have been here since berlin, so this is just wiring them in. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> * Convert start and count from hex to match JSON-RPC Spec standard Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> --------- Signed-off-by: Zhenyang Shi <wcgcyx@gmail.com> Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Co-authored-by: Zhenyang Shi <wcgcyx@gmail.com> Co-authored-by: Simon Dudley <simon.dudley@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: Daniel Lehrner <daniel.lehrner@consensys.net> Co-authored-by: Danno Ferrin <danno.ferrin@swirldslabs.com>

…yperledger#5039)" (hyperledger#5073) This reverts commit e715010. Signed-off-by: Simon Dudley <simon.dudley@consensys.net>

Signed-off-by: Jason Frame <jason.frame@consensys.net>

…5068) Signed-off-by: Jason Frame <jason.frame@consensys.net>

* change validation to lessThan Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Change exception message to PoS instead of Near head Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Add unit test and fix message of existing unit test Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> --------- Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

Signed-off-by: Justin Florentine <justin+github@florentine.us>

gradle.properties

garyschulte

diff against origin/main LGTM. Good by me as soon as DCO is sorted out

siladu

I can't see Gary's latest change in the full file diff for some reason, I suspect a bad merge?

CHANGELOG.md

jframe · 2023-02-17T05:14:34Z

I can't see Gary's latest change in the full file diff for some reason, I suspect a bad merge?
Is it this change ac23d31 your looking for?

siladu · 2023-02-17T05:16:31Z

I can't see Gary's latest change in the full file diff for some reason, I suspect a bad merge?
Is it this change ac23d31 your looking for?

Yeh it's not in the file diff, nor the merge commit diff c1eca61

garyschulte · 2023-02-17T05:17:05Z

I can't see Gary's latest change in the full file diff for some reason, I suspect a bad merge?

it won't show in the diff because I merged it into release-23.1.x for the 23.1.0 build

siladu

LGTM

Signed-off-by: garyschulte <garyschulte@gmail.com>

* rebase off of burn-in release, remove unreleased 23.1.0-RC2 from CHANGELOG Signed-off-by: garyschulte <garyschulte@gmail.com> Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net> Signed-off-by: Karim TAAM <karim.t2am@gmail.com>

…edger#5105) * default global max rpc batch size to 1000 for now Signed-off-by: garyschulte <garyschulte@gmail.com>

* Use the copy during prepareTrieLog instead of saveTrieLog * add final flag on BonsaiWorldStateUpdater * Use a copy of BonsaiInMemoryWorldState inside prepareTrieLog * add link to persisted worldstate storage * fix tests * Make a copy of the worldstate after committing changes to the trielog * spotless + remove maybeUnSubscribe in setNextWorldView * subscribe storage on layered worldstate * fix null issue * not close layered worldstate during getAccount * clean code * Add changelog entry --------- Signed-off-by: ahamlat <ameziane.hamlat@consensys.net> Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Co-authored-by: Karim TAAM <karim.t2am@gmail.com>

Update and fix forkId tests Move timestamp forks from getForkBlockNumbers to getForkBlockTimestamps in JsonGenesisConfigOptions - this ultimately gets used to popoulate the ForkIdManager which handles lists of blocks and timestamps the same way so this hasn't changed any actual behaviour, but rather supports the test fixes. Implement TransitionProtocolSchedule.streamMilestoneBlocks as a concatenation of blockNumbers++blockTimestamps. This may have been a latent bug since it's used to update the node record when a fork transition occurs. Signed-off-by: Simon Dudley <simon.dudley@consensys.net>

hyperledger#5048) * If a PoS block creation repetition takes less than a configurable duration, then waits before next repetition Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> * Update CHANGELOG Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> * Add unit test Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> * Update besu/src/main/java/org/hyperledger/besu/cli/BesuCommand.java Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> * Update besu/src/main/java/org/hyperledger/besu/cli/options/unstable/MiningOptions.java Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> --------- Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>

…t PoS (Revert PR#3911) (hyperledger#5083) * reintroduce checking of block height for certain tasks when we are not PoS (Revert PR#3911) Signed-off-by: Stefan Pingel <16143240+pinges@users.noreply.github.com>

…edger#5092) Signed-off-by: Rafael Matias <rafael@skyle.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

…#5066) Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

* Add gasUsed calculation Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Fix unit test Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Fix typo Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> --------- Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

Signed-off-by: Jason Frame <jason.frame@consensys.net>

siladu

LGTM

siladu and others added 7 commits February 8, 2023 16:06

Prepare for version 23.1.1-SNAPSHOT (hyperledger#5067)

fd90643

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>

Revert "Keep Worldstate Storage open for Bonsai archive latest layer (h…

d7afa41

…yperledger#5039)" (hyperledger#5073) This reverts commit e715010. Signed-off-by: Simon Dudley <simon.dudley@consensys.net>

Support post merge forks at genesis for hive tests (hyperledger#5019)

b2d378e

Signed-off-by: Jason Frame <jason.frame@consensys.net>

Fix manifest docker not skipping interim builds for RCs (hyperledger#…

01b16bd

…5068) Signed-off-by: Jason Frame <jason.frame@consensys.net>

moves check for init code length before balance check (hyperledger#5077)

56ae1fc

Signed-off-by: Justin Florentine <justin+github@florentine.us>

garyschulte reviewed Feb 17, 2023

View reviewed changes

gradle.properties Show resolved Hide resolved

garyschulte approved these changes Feb 17, 2023

View reviewed changes

siladu requested changes Feb 17, 2023

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

siladu approved these changes Feb 17, 2023

View reviewed changes

garyschulte added 3 commits February 17, 2023 16:21

bump revision for 23.1.x release branch

3ca8db3

Signed-off-by: garyschulte <garyschulte@gmail.com>

re-default global max rpc batch size to 1k (hyperledger#5104) (hyperl…

46168f6

…edger#5105) * default global max rpc batch size to 1000 for now Signed-off-by: garyschulte <garyschulte@gmail.com>

jframe force-pushed the release_23.1.1-RC1 branch from 460d86d to 103d1ad Compare February 17, 2023 06:23

ahamlat and others added 4 commits February 17, 2023 16:26

Allow dashes in ethstats password (hyperledger#5090)

b7258cc

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>

jframe force-pushed the release_23.1.1-RC1 branch from 103d1ad to 6ec17d5 Compare February 17, 2023 06:27

pinges and others added 5 commits February 17, 2023 16:28

reintroduce checking of block height for certain tasks when we are no…

017b2d2

…t PoS (Revert PR#3911) (hyperledger#5083) * reintroduce checking of block height for certain tasks when we are not PoS (Revert PR#3911) Signed-off-by: Stefan Pingel <16143240+pinges@users.noreply.github.com>

Allow other users to read the /opt/besu dir when using docker (hyperl…

73ccac6

…edger#5092) Signed-off-by: Rafael Matias <rafael@skyle.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>

Only use MAINNET version of KZG (hyperledger#5095)

860fc9b

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

add more context to exception messages and debug logging (hyperledger…

d26b039

…#5066) Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

jframe force-pushed the release_23.1.1-RC1 branch from 6ec17d5 to f36165a Compare February 17, 2023 06:28

Add 23.1.1-RC1 changelog

9ac70d6

Signed-off-by: Jason Frame <jason.frame@consensys.net>

jframe added 2 commits February 17, 2023 17:02

Merge branch 'release-23.1.x' into release_23.1.1-RC1

114bd86

Change version to 23.1.1-RC1

4c9dd3e

Signed-off-by: Jason Frame <jason.frame@consensys.net>

siladu approved these changes Feb 17, 2023

View reviewed changes

Merge branch 'release-23.1.x' into release_23.1.1-RC1

6e8eff2

jframe merged commit d048798 into hyperledger:release-23.1.x Feb 17, 2023

jframe mentioned this pull request Feb 20, 2023

Release 23.1.1 rc1 2 #5107

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release 23.1.1 rc1 #5106

Release 23.1.1 rc1 #5106

jframe commented Feb 17, 2023 •

edited

Loading

garyschulte left a comment

siladu left a comment

jframe commented Feb 17, 2023

siladu commented Feb 17, 2023

garyschulte commented Feb 17, 2023

siladu left a comment

siladu left a comment

Release 23.1.1 rc1 #5106

Release 23.1.1 rc1 #5106

Conversation

jframe commented Feb 17, 2023 • edited Loading

PR description

Fixed Issue(s)

Documentation

Acceptance Tests (Non Mainnet)

Changelog

garyschulte left a comment

Choose a reason for hiding this comment

siladu left a comment

Choose a reason for hiding this comment

jframe commented Feb 17, 2023

siladu commented Feb 17, 2023

garyschulte commented Feb 17, 2023

siladu left a comment

Choose a reason for hiding this comment

siladu left a comment

Choose a reason for hiding this comment

jframe commented Feb 17, 2023 •

edited

Loading