[23.4] Remove GoQuorum privacy

[macfarla]

Remove GoQuorum compatible privacy

Fixes #4886

• next release is 23.4
• acceptanceTestsNonMainnet passed in CI
• Besu with other types of privacy still works as expected

[github-actions]

• I thought about documentation and added the doc-change-required label to this PR if updates are required.
• I have considered running ./gradlew acceptanceTestNonMainnet locally if my PR affects non-mainnet modules.
• I thought about the changelog and included a changelog update if required.

[macfarla]

with this change - if you send a GoQuorum private transaction via EthSigner, it is rejected with "method not enabled" because it sends a goquorum_storeRaw to Besu which Besu rejects
-> suggested change to EthSigner Consensys/ethsigner#500 - to actively reject this type of transaction

[pinges]

I've done a "find all" within Besu for goquorum and I found a few error codes in JsonRpcError.java that are related to goquorum privacy:
GOQUORUM_NO_PRIVATE_FOR
GOQUORUM_ONLY_STANDARD_MODE_SUPPORTED
GOQUORUM_LOOKUP_ID_NOT_AVAILABLE
GOQUORUM_V_VALUE

In RpcMethod.java I found
GOQUORUM_ETH_GET_QUORUM_PAYLOAD
GOQUORUM_STORE_RAW

In BlockHeader.java there is a method that returns the private logs bloom:
getPrivateLogsBloom()

We might be able to get rid of the v parameter for Transaction (org/hyperledger/besu/ethereum/core/Transaction.java)

There is a method on BlockProcessor line 149 that we should be able to get rid of

KeyValueSegmentIdentifier.java contains
GOQUORUM_PRIVATE_WORLD_STATE
GOQUORUM_PRIVATE_STORAGE

TransactionDecoderTest.java lines 41 and 88

That's all I can find right now :-)

[macfarla]

I've done a "find all" within Besu for goquorum and I found a few error codes in JsonRpcError.java that are related to goquorum privacy: GOQUORUM_NO_PRIVATE_FOR GOQUORUM_ONLY_STANDARD_MODE_SUPPORTED GOQUORUM_LOOKUP_ID_NOT_AVAILABLE GOQUORUM_V_VALUE

In RpcMethod.java I found GOQUORUM_ETH_GET_QUORUM_PAYLOAD GOQUORUM_STORE_RAW

In BlockHeader.java there is a method that returns the private logs bloom: getPrivateLogsBloom()

We might be able to get rid of the v parameter for Transaction (org/hyperledger/besu/ethereum/core/Transaction.java)

There is a method on BlockProcessor line 149 that we should be able to get rid of

KeyValueSegmentIdentifier.java contains GOQUORUM_PRIVATE_WORLD_STATE GOQUORUM_PRIVATE_STORAGE

TransactionDecoderTest.java lines 41 and 88

That's all I can find right now :-)

Thanks @pinges removed all those things!

[macfarla]

with this change - if you send a GoQuorum private transaction via EthSigner, it is rejected with "method not enabled" because it sends a goquorum_storeRaw to Besu which Besu rejects -> suggested change to EthSigner ConsenSys/ethsigner#500 - to actively reject this type of transaction

Leaving EthSigner as is. User will get "method not enabled" if they try to send a GoQuorum private tx via EthSigner to Besu.

[shemnon]

I really like how this removes GoQuorumOptions

[lucassaldanha]

End of an era!

[non-fungible-nelson]

Reminder to merge for tomorrow @macfarla